Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAY-3748] Fix logged out state #10871

Closed
wants to merge 1 commit into from
Closed

[PAY-3748] Fix logged out state #10871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/harmony/.svgrrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module.exports = {
titleProp: true,
descProp: true,
replaceAttrValues: {
red: '{props.fillColor}',
'#FF0000': '{props.fillColor}'
red: '{props.fillcolor}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up I fix this in an open pr, mind dropping?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

'#FF0000': '{props.fillcolor}'
}
}
1 change: 0 additions & 1 deletion packages/harmony/src/components/button/BaseButton/BaseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
userSelect: 'none',
whiteSpace: 'nowrap',
paddingInline: 0,
'-webkit-padding': 0,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik, this is not actually a thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here btw, but all good

transition: `
transform ${motion.hover},
border-color ${motion.hover},
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/.svgrrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module.exports = {
titleProp: true,
descProp: true,
replaceAttrValues: {
'#FF0000': '{props.fillColor}',
'#FF0000': '{props.fillcolor}',
'#000': '{props.fill}',
'#f00': '{props.fillSecondary}'
}
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/src/sdk/services/AudiusWalletClient/createHedgehogWalletClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ export function createHedgehogWalletClient(
let account_: AudiusAccount | undefined
const getAccount = async () => {
await hedgehog.waitUntilReady()
const wallet = hedgehog.getWallet()
let wallet = hedgehog.getWallet()
if (!wallet) {
throw new Error('Hedgehog wallet not found. Is the user logged in?')
wallet = await hedgehog.createWalletObj(Date.now().toString())
}

if (!account_ || account_.address !== wallet.getAddressString()) {
Expand Down
2 changes: 1 addition & 1 deletion packages/web/.svgrrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module.exports = {
titleProp: true,
descProp: true,
replaceAttrValues: {
'#FF0000': '{props.fillColor}',
'#FF0000': '{props.fillcolor}',
'#000': '{props.fill}',
'#f00': '{props.fillSecondary}'
}
Expand Down
3 changes: 2 additions & 1 deletion packages/web/src/pages/trending-page/components/desktop/TrendingGenreFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ export const TrendingGenreFilters = (props: TrendingGenreFiltersProps) => {
// even if it's not selected.
if (
isSelectedFromModal(currentGenre) &&
currentGenre !== lastModalSelectedGenre
currentGenre !== lastModalSelectedGenre &&
currentGenre
) {
genres.push(currentGenre)
} else if (lastModalSelectedGenre) {
Expand Down
4 changes: 2 additions & 2 deletions svgr-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ const ${variables.componentName} = forwardRef((${variables.props}, ref) => {
other.width = width
}

const fillColor = other.fill ?? theme.color?.icon[color] ?? 'red'
const fillcolor = other.fill ?? theme.color?.icon[color] ?? 'red'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fillcolor is right not fillColor


${native ? nativeStyles : webStyles}

other.role = title ? 'img' : undefined
other['aria-hidden'] = title ? undefined : true

props = {...other, ref, fillColor}
props = {...other, ref, fillcolor}

${native ? `const Path = animatedProps ? AnimatedPath : RNSVGPath` : ''}

Expand Down