Gutenberg Comments test #1729
Gutenberg Comments test #1729
Conversation
|
Since Gutenberg is released into prod now I thought it best to just add the comments tests within the wp-comments-spec vs wp-calypso-gutenberg, just to make it a little easier once we phase out the classic editor spec |
|
So, I should have been clearer on the issue, but what I meant was "Allow Comments" checkbox in the editor. We want to ensure that if that box isn't checked, then comments cannot be added. |
Ahhh I see! Misunderstood I've removed the command from PR that would close #1645, @bsessions85 should we still merge this though? |
specs/wp-comments-spec.js
Outdated
| } ); | ||
|
|
||
| step( 'Can post a reply', async function() { | ||
| await driver.sleep( 10000 ); // Wait to not to post too quickly |
There was a problem hiding this comment.
Looks like you are creating work for @juliaamosova 😃
Why this sleep is needed? Is it doable to wait for the comment to be posted?
There was a problem hiding this comment.
This is there, I believe, to keep spam triggers from being set off. If you post comments too quickly you'll get errors saying you need to slow down. This one has to be there.
There was a problem hiding this comment.
If the sleep statement is here to address the spam issue indeed, we'd need to keep it. I will, however, research if there is any way around that when get to work on this test.
There was a problem hiding this comment.
I just ran this a bunch of times without the sleep and it actually doesn't appear to be a spam thing, it is just waiting for the comment to show up. This should be updated to wait for the comment to show up
There was a problem hiding this comment.
OK I'll merge with the sleep since @juliaamosova is already going through all the sleeps
There was a problem hiding this comment.
Sounds good to me @JavonDavis ! I'll implement the wait and check for the comment as suggested by @bsessions85 which should address the sleep statement here.
My initial though was no, but I guess it is one more we won't have to change when we switch all the tests to using Gutenberg. I am not sure about whether we should keep the old one at this point though. |
I was thinking the same 🤔🤔 I'm just going to remove the old one I'm not sure it's of much use at the moment and will be of less use in the coming weeks |
|
FYI: This PR break comments test for Jetpack sites, which was specifically created for Jetpack: #1406 |
This PR adds a test for comments on a post made via Gutenberg Editor
To test:
specs/wp-comments-spec.js