Edge device creation, configuration, and device bundles #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added help and examples for edge hierarchy commands Modified inline device args to parse 'id' instead of 'device_id' for brevity, updated tests
Certificate whitespace fixes added all --device arg config values Updated unit tests Added device bundle checks to integration tests
Moved new tuples / classes to shared Fixed linter issues and styling
7 tasks
digimaun
reviewed
Oct 27, 2022
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 7, 2023
…-k/azure-iot-cli-extension into nested_edge_device_bundle
Remnamed ca_cert input vars for create_ca_signed_certificate Changed default value to 'n' for --clean Updated help text and params with aka.ms link Changed --device-template to --device-config-template
digimaun
reviewed
Jan 7, 2023
digimaun
reviewed
Jan 7, 2023
digimaun
reviewed
Jan 7, 2023
digimaun
reviewed
Jan 7, 2023
digimaun
reviewed
Jan 7, 2023
digimaun
approved these changes
Jan 7, 2023
Moved logic into --clean functionality
7 tasks
|
First round of tests - have one final one (hopefully) coming that updates unit and integration tests so I'll have another run starting shortly. https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7310&view=results |
Makes paths inside config file relative to config file Does not apply relative pathing to override params (CLI context) Updates tests and adds nested folder for deployments to test pathing differences
|
Ok, one last full pipeline run to go once the PR pipeline passes, but here's some local testing evidence: |
|
Looks like tests were mostly successful, save some of our recent recurring issues. I'm good with this. |
c-ryan-k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
az iot edge devices createcommand that allows users to create and configure multiple edge device scenarios (and associated device configuration settings) using a configuration file (YAML or JSON) or inline device arguments.The command performs the following actions after processing input:
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
devormainare of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrcand.flake8rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).