AP_ICEngine: TCA9554 changes motor direction to reverse #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
approved these changes
Mar 4, 2024
This already been tested on our previous commits on ottano/dev branch but was dropped in this as we fixed the direction for all other aircrafts. |
|
Do NOT Merge |
| @@ -16,7 +16,8 @@ class AP_ICEngine_TCA9554 { | |||
|
|
|||
| enum TCA9554_state_t { | |||
| STARTER_OFF = 0x30, // output register - 0011 0000 | |||
| STARTER_ON = 0x11, // output register - 0001 0001 - Forward direction | |||
| STARTER_ON = 0x01, // output register - 0000 0001 - Reverse direction | |||
There was a problem hiding this comment.
Do you think we should have a custom build as long as any aircraft with this engine type is in service ?
Maybe have #define ICENGINE_REVERSE.
Make custom builds also !
OR
have a config parameter that can reverse this (need to check this !)
This is a hard change of direction for O4 aircraft only. SW-111:Custom ANU build for reverse engine - This fix will be there until any aircraft with reverse engine rotation is in service - Build folder limited to 24 chars fix
Pradeep-Carbonix
force-pushed
the
feature/SW-111-tridge-custom-firmware-based-on-carbo-v-5-0-0
branch
from
5710e18 to
75b268d
Compare
Jono453
approved these changes
Mar 19, 2024
Jono453
reviewed
Mar 19, 2024
| @@ -15,8 +15,12 @@ class AP_ICEngine_TCA9554 { | |||
| AP_HAL::OwnPtr<AP_HAL::I2CDevice> dev_TCA9554; | |||
|
|
|||
| enum TCA9554_state_t { | |||
| STARTER_OFF = 0x30, // output register - 0011 0000 | |||
| STARTER_ON = 0x11, // output register - 0001 0001 - Forward direction | |||
| STARTER_OFF = 0x30, // output register - 0011 0000 | |||
|
This has been handled in an other PR where this is configurable. |
ghost
closed this
robertlong13
deleted the
feature/SW-111-tridge-custom-firmware-based-on-carbo-v-5-0-0
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hard change of direction for O4 aircraft only. (ANU Aircraft)
SW-111