Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContinuousControl node #1602

Merged
merged 28 commits into from
Jul 23, 2024
Merged

Add ContinuousControl node #1602

merged 28 commits into from
Jul 23, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #720.

@SouthEndMusic SouthEndMusic marked this pull request as draft July 2, 2024 12:37
@SouthEndMusic SouthEndMusic changed the title Towards implementation of ContinuousControl Add ContinuousControl node Jul 2, 2024
@visr visr mentioned this pull request Jul 15, 2024
Closed
2 tasks
@SouthEndMusic SouthEndMusic mentioned this pull request Jul 16, 2024
Closed
@SouthEndMusic SouthEndMusic marked this pull request as ready for review July 17, 2024 16:20
@SouthEndMusic SouthEndMusic requested a review from visr July 17, 2024 16:20
@SouthEndMusic
Copy link
Collaborator Author

For those wondering why the diff is so big: this is a large PR, but the majority now actually comes from changes to pixi.lock. I don't know what is happening there, the file keeps being updated automatically. I saw I am behind on my pixi version, so I now upgraded to 0.25.0.

visr
visr reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.
As discussed, let's remove min_output and max_output as well. I also noticed we need to update SPATIALCONTROLNODETYPES in ribasim_qgis.

docs/reference/node/continuous-control.qmd Outdated Show resolved Hide resolved
docs/reference/node/continuous-control.qmd Outdated Show resolved Hide resolved
core/src/sparsity.jl Show resolved Hide resolved
core/src/solve.jl Outdated Show resolved Hide resolved
core/src/solve.jl Show resolved Hide resolved
core/src/read.jl Outdated Show resolved Hide resolved
core/src/parameter.jl Outdated Show resolved Hide resolved
core/src/parameter.jl Outdated Show resolved Hide resolved
core/src/parameter.jl Show resolved Hide resolved
@visr visr mentioned this pull request Jul 23, 2024
Closed
@SouthEndMusic SouthEndMusic requested a review from visr July 23, 2024 11:39
@visr visr merged commit 5ff6010 into main Jul 23, 2024
25 checks passed
@visr visr deleted the continuous_control branch July 23, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support continuous controller
2 participants
@SouthEndMusic @visr