Only gravity driven Outlet flow
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
changed the title
Outlet flow
|
I made this plot of the smooth reduction factor:
|
|
I found something peculiar when working on the test model for the
In the current state it behaves as expected, that is: there is no outlet flow until the level boundary reaches the minimum crest level, and the basin level converges to the level boundary level. However, when the basin starts completely empty instead of with a tiny amount of water, it doesn't fill:
I haven't been able to figure out why this happens. |
This is easier on the compiler, generally recommended for performance.
I prefer to avoid yellow since it is the color of selected nodes in QGIS.
Closed
Making it not show up in QGIS.
visr
approved these changes
Sep 13, 2023
visr
added a commit
that referenced
this pull request
Sep 14, 2023
Fixes #548. Currently the outlet switches on and off in a discrete way due to a switch in sign of the level difference. This can result in the outlet rapidly turning on and off:  To solve this problem, a reduction factor should be applied to the outlet flow, based on the level difference. This reduction factor will have to be taken into account in the implementation of the analytical Jacobian (with an unsatisfying effort to improvement ratio). This I think will be a recurring problem until we are able to switch to an AD Jacobian. --------- Co-authored-by: Martijn Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548.
Currently the outlet switches on and off in a discrete way due to a switch in sign of the level difference. This can result in the outlet rapidly turning on and off:
To solve this problem, a reduction factor should be applied to the outlet flow, based on the level difference. This reduction factor will have to be taken into account in the implementation of the analytical Jacobian (with an unsatisfying effort to improvement ratio). This I think will be a recurring problem until we are able to switch to an AD Jacobian.