♻️ Enhanced ContributorsScreen testing. #503
Conversation
… Staff data class and Contributor data class.
modified to check if the elements of individual items are visible.
Corvus400
changed the title
| itShould("show contributor 1 to 5") { | ||
| captureScreenWithChecks { | ||
| checkExistsContributorItem( | ||
| fromTo = 0 to 5, | ||
| ) | ||
| } | ||
| } | ||
| describe("when scroll to contributor 9") { | ||
| run { | ||
| scrollToTestTag(ContributorsItemTestTag.plus(9)) | ||
| } | ||
| itShould("show contributor 6 to 10") { | ||
| captureScreenWithChecks { | ||
| checkExistsContributorItem( | ||
| fromTo = 5 to 10, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Thanks. However, I think this test is highly dependent on screen size and can easily break. I believe it would be better to check if we have two or more items.
…ther two or more contributors are displayed.
|
Maybe |
| run { | ||
| setupScreenContent() | ||
| } | ||
| itShould("does not show contributor, and show snackbar") { |
…nshots not displaying if there is a comma in them.
![ContributorsScreenTest[ContributorsScreen - when server is operational - when server is down - when launch - it should does not show contributor and show snackbar]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/contributors_screen_test_enhancement/./screenshot-diff-reports/feature/contributors/build/outputs/roborazzi/ContributorsScreenTest%5BContributorsScreen%20-%20when%20server%20is%20operational%20-%20when%20server%20is%20down%20-%20when%20launch%20-%20it%20should%20does%20not%20show%20contributor%20and%20show%20snackbar%5D_compare.png){kind=link}
![ContributorsScreenTest[ContributorsScreen - when server is operational - when launch - it should show first and second contributors]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/contributors_screen_test_enhancement/./screenshot-diff-reports/feature/contributors/build/outputs/roborazzi/ContributorsScreenTest%5BContributorsScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20show%20first%20and%20second%20contributors%5D_compare.png){kind=link}
![ContributorsScreenTest[ContributorsScreen - when server is operational - when launch - when scroll to index 10 - it should show contributors]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/contributors_screen_test_enhancement/./screenshot-diff-reports/feature/contributors/build/outputs/roborazzi/ContributorsScreenTest%5BContributorsScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20when%20scroll%20to%20index%2010%20-%20it%20should%20show%20contributors%5D_compare.png){kind=link}
![ContributorsScreenTe st[ContributorsScreen - when server is operational - when server is down - when launch - it should does not show contributor, and show snackbar]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/contributors_screen_test_enhancement/screenshot-diff-reports/feature/contributors/build/outputs/roborazzi/ContributorsScreenTest%5BContributorsScreen%20-%20when%20server%20is%20operational%20-%20when%20server%20is%20down%20-%20when%20launch%20-%20it%20should%20does%20not%20show%20contributor,%20and%20show%20snackbar%5D_compare.png){kind=link}
|
Let me push some changes for this 🙏 |
|
Detekt check failed. Please run |
|
@Corvus400 I've pushed some changes. Do you have any thoughts on them? |
| @@ -34,6 +34,8 @@ import kotlinx.collections.immutable.PersistentList | |||
|
|
|||
| const val contributorsScreenRoute = "contributors" | |||
| const val ContributorsScreenTestTag = "ContributorsScreenTestTag" | |||
| const val ContributorsTestTag = "ContributorsTestTag" | |||
| const val ContributorsItemTestTagPrefix = "ContributorsItemTestTag:" | |||
There was a problem hiding this comment.
Surely this is a prefix.
I think this name is better! 👍
| const val ContributorsItemImageTestTagPrefix = "ContributorsItemImageTestTag:" | ||
| const val ContributorsUserNameTextTestTagPrefix = "ContributorsUserNameTextTestTag:" |
There was a problem hiding this comment.
@takahirom
I have modified the name of this test tag since it is used as a Prefix as well. 👍
| fun scrollToIndex10() { | ||
| composeTestRule | ||
| .onNode(hasTestTag(ContributorsTestTag)) | ||
| .performScrollToIndex(10) | ||
| } |
There was a problem hiding this comment.
I see, in this case the scrolling method using Index was better. ✍️
| @@ -0,0 +1,60 @@ | |||
| package io.github.droidkaigi.confsched.testing.utils | |||
There was a problem hiding this comment.
These Utils are very helpful as I am sure they will be used frequently in other test cases! 🙇♂️
…enhancement/contributors_screen_test_enhancement # Conflicts: # feature/contributors/src/commonMain/kotlin/io/github/droidkaigi/confsched/contributors/ContributorsScreen.kt
|
@takahirom |
|
I've changed some test names. Thank you for your collaboration! |
Issue
xxxxScreenTesttests #464Overview (Required)