Add overflow menu to mini context menu #34031

esh-g · 2024-01-05T15:27:02Z

Details

Fixed Issues

Tests

Send a message in any report
Right click and make sure we see the option 'leave thread'
Click on 'leave thread'
Right click on message again
Make sure 'join thread' is displayed.
Hover over a report action
Make sure it matches the layout below:

Make sure the following options are displayed in mini context menu for the specific items.

Action type	Items
Task	Reply in thread, mark as unread/read
Sent message	Reply in thread, edit action
Attachment	Download, reply in thread
Received message	Reply in thread, mark as Unread
Money report preview	Reply in Thread, Mark as unread
Split bill	Mark as unread, copy to clipboard
Money request action	Reply in thread, edit request

Click on the ThreeDot menu and make sure the context menu is displayed.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Send a message in any report
Right click and make sure we see the option 'leave thread'
Click on 'leave thread'
Right click on message again
Make sure 'join thread' is displayed.
Hover over a report action
Make sure it matches the layout below:

Make sure the following options are displayed in mini context menu for the specific items.

Action type	Items
Task	Reply in thread, mark as unread/read
Sent message	Reply in thread, edit action
Attachment	Download, reply in thread
Received message	Reply in thread, mark as Unread
Money report preview	Reply in Thread, Mark as unread
Split bill	Mark as unread, copy to clipboard
Money request action	Reply in thread, edit request

Click on the ThreeDot menu and make sure the context menu is displayed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-12.at.1.55.00.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-12.at.1.58.32.PM.mov

iOS: Native

Screen.Recording.2024-01-11.at.5.08.22.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-12.at.2.01.50.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-11.at.5.11.50.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-11.at.5.24.40.PM.mov

Screen.Recording.2024-01-11.at.5.26.39.PM.mov

melvin-bot · 2024-01-05T15:27:07Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

esh-g · 2024-01-05T15:52:25Z

@rushatgabhane The task of adding the new icons is still pending...

Could you please let me know how we should go about these?

src/styles/utils/generators/ReportActionContextMenuStyleUtils.ts

src/components/ContextMenuItem.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

rushatgabhane · 2024-01-08T03:02:29Z

@esh-g please make sure that the performance tests pass.

rushatgabhane · 2024-01-08T03:03:21Z

The task of adding the new icons is still pending

we got the icons here! - #33573 (comment)

esh-g · 2024-01-08T17:03:27Z

@rushatgabhane I have added the icons, fixed the lint and replied to the review comments. Let me know if anything is unclear!

rushatgabhane · 2024-01-10T03:14:23Z

@esh-g could you please add screenshots for all platforms and fix conflicts

src/components/Reactions/MiniQuickEmojiReactions.tsx

rushatgabhane

Bug: For a task, we're showing three dot menu two times.

Happens for system messages too. Please fix the root cause of this @esh-g

esh-g · 2024-01-10T08:35:27Z

@rushatgabhane I wanted to ask if the steps in the tests are correct before attaching the test videos... Should I also include tests for things like money reports, attachments, tasks etc?

Also, I made a small pivot where instead of using isMini for all menu items, I just re-arranged them according to priority and I hope that covers cases like money report, tasks, attachments etc..

src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

rushatgabhane

please fix the typescript errors too

esh-g · 2024-01-10T11:05:53Z

@rushatgabhane Could you please confirm if the test steps are right?

dubielzyk-expensify · 2024-01-11T23:00:28Z

This is awesome work and a great start!

Not sure if you're splitting this up into multiple PRs, but I'll give all my feedback here anyways:

We're missing new icons for Reply in thread and Mark as unread on Android and Web. Other platforms look correct
Unsubscribe from thread should become Leave thread on all platforms
Subscribe to thread should become Join thread on all platforms
The overflow menu isn't correct on desktop. It shouldn't replicate the overflow menu like mobile, but rather just show the missing options. See mock underneath:

esh-g · 2024-01-12T08:14:42Z

@dubielzyk-expensify Actualy I just realised that I tested the wrong branch (Was working on another bug) and attached videos for that in the PR. Will change that to the correct videos.

The overflow menu isn't correct on desktop. It shouldn't replicate the overflow menu like mobile, but rather just show the missing options. See mock underneath:

Yes, I was aware of this and has been discussed in slack here to be like this

esh-g · 2024-01-12T08:35:13Z

@dubielzyk-expensify @rushatgabhane I have updated this with the correct videos. Please let me know if anything is pending!

quinthar · 2024-01-12T23:33:38Z

Who is this waiting on? Can we merge today?

dubielzyk-expensify · 2024-01-14T23:07:09Z

Everything looks good except for the overflow on desktop. We're still seeing the full overflow menu:

It should look like this:

esh-g · 2024-01-15T02:33:36Z

@dubielzyk-expensify Yes, I was aware of this and has been discussed in slack here to be like this. Please bring your opinion to slack so that we can decide

dubielzyk-expensify · 2024-01-15T03:18:36Z

Thanks for that. Sorry, I was going through my GitHub issue before Slack this morning :) I've replied on the thread. Awaiting designers feedback, then we can charge ahead with the final decision. Thanks for raising this, @esh-g 👍

rushatgabhane · 2024-01-15T05:07:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

LGTM!

@esh-g @dubielzyk-expensify i think we can do that in a follow up PR after the discussion is done, it should be a small change.

So we can merge this PR. What do you think?

mountiny · 2024-01-16T23:48:30Z

@esh-g can you resolve merge conflicts and retest afterwards please?

@rushatgabhane could you give it a quick test after that too please?

quinthar · 2024-01-17T01:13:17Z

Looks like this is going great -- can we get this merged today so we can deploy it to staging tomorrow?

esh-g · 2024-01-17T04:12:08Z

Fixing conflicts now

esh-g · 2024-01-17T08:02:39Z

@rushatgabhane @mountiny I encountered a bug that when you select the three dot menu with keyboard, it shows up in the corner. I tried to prevent this but I think this is because the pageX and pageY are set to 0 in KeyboardEvent which is what the PopoverContextMenu relies on for it's position. Should we look for a solution to this or is this not a priority?

I have re-tested everything else and seems to work..

Screen.Recording.2024-01-17.at.12.40.33.PM.mov

mountiny · 2024-01-17T12:54:04Z

I dont think we have to hold for this we are still not focusing on accessibility features

That being said i think you should aim for fix that in the following up pr in scope of this task as this is essentially an UX regression introduced by this change @esh-g

mountiny

Thanks!

OSBotify · 2024-01-18T02:00:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-18T03:25:42Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-19T09:45:28Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add overflow menu to mini context menu

e579509

esh-g requested a review from a team as a code owner January 5, 2024 15:27

melvin-bot bot requested review from rushatgabhane and removed request for a team January 5, 2024 15:27

esh-g added 2 commits January 5, 2024 21:11

fix lint

ccd4983

fix lint

a24941a

rushatgabhane suggested changes Jan 8, 2024

View reviewed changes

esh-g added 4 commits January 8, 2024 21:27

Prettify 💫

bf88b1a

Merge branch 'main' into overflow-menu

2e8961f

Add icons

73eae87

Prettify

8ed9318

esh-g mentioned this pull request Jan 9, 2024

[HOLD for payment 2024-01-26] [$600] CRITICAL: Updates to Comment Action menu #33573

Closed

12 tasks

rushatgabhane suggested changes Jan 10, 2024

View reviewed changes

src/components/Reactions/MiniQuickEmojiReactions.tsx Outdated Show resolved Hide resolved

rushatgabhane suggested changes Jan 10, 2024

View reviewed changes

Fix bug

150702f

esh-g added 2 commits January 10, 2024 14:06

Merge branch 'main' into overflow-menu

71b593d

Correct items number

302e3be

rushatgabhane reviewed Jan 10, 2024

View reviewed changes

src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js Outdated Show resolved Hide resolved

rushatgabhane suggested changes Jan 10, 2024

View reviewed changes

esh-g added 2 commits January 10, 2024 17:05

Fix types and CONST

5d83979

Fix lint

270d46b

dubielzyk-expensify self-requested a review January 10, 2024 23:56

rushatgabhane approved these changes Jan 15, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny January 15, 2024 05:12

dubielzyk-expensify previously approved these changes Jan 15, 2024

View reviewed changes

Merge branch 'main' into overflow-menu

243e001

Make changes after TS migration

032aa6a

esh-g dismissed dubielzyk-expensify’s stale review via 032aa6a January 17, 2024 08:07

esh-g added 2 commits January 17, 2024 13:41

Fix lint

5c62754

Fix lint

a697f71

mountiny approved these changes Jan 18, 2024

View reviewed changes

mountiny assigned esh-g Jan 18, 2024

mountiny merged commit 99d5850 into Expensify:main Jan 18, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 18, 2024

Deploy Checklist: New Expensify 2024-01-18 #34701

Closed

31 tasks

esh-g mentioned this pull request Jan 18, 2024

[HOLD for payment 2024-02-07] Context menu - Context menu opens in LHN when navigating via Tab and Enter key #34739

Closed

6 tasks

ZhenjaHorbach mentioned this pull request Jan 25, 2024

[$500] Web - Chat - "Fire" is missing from the suggested emojis #35199

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add overflow menu to mini context menu #34031

Add overflow menu to mini context menu #34031

esh-g commented Jan 5, 2024 •

edited

Loading

melvin-bot bot commented Jan 5, 2024

esh-g commented Jan 5, 2024

rushatgabhane commented Jan 8, 2024

rushatgabhane commented Jan 8, 2024

esh-g commented Jan 8, 2024

rushatgabhane commented Jan 10, 2024

rushatgabhane left a comment •

edited

Loading

esh-g commented Jan 10, 2024 •

edited

Loading

rushatgabhane left a comment

esh-g commented Jan 10, 2024

dubielzyk-expensify commented Jan 11, 2024

esh-g commented Jan 12, 2024

esh-g commented Jan 12, 2024

quinthar commented Jan 12, 2024

dubielzyk-expensify commented Jan 14, 2024

esh-g commented Jan 15, 2024

dubielzyk-expensify commented Jan 15, 2024

rushatgabhane commented Jan 15, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

mountiny commented Jan 16, 2024

quinthar commented Jan 17, 2024

esh-g commented Jan 17, 2024

esh-g commented Jan 17, 2024 •

edited

Loading

mountiny commented Jan 17, 2024

mountiny left a comment

OSBotify commented Jan 18, 2024

OSBotify commented Jan 18, 2024

OSBotify commented Jan 19, 2024

Add overflow menu to mini context menu #34031

Add overflow menu to mini context menu #34031

Conversation

esh-g commented Jan 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 5, 2024

esh-g commented Jan 5, 2024

rushatgabhane commented Jan 8, 2024

rushatgabhane commented Jan 8, 2024

esh-g commented Jan 8, 2024

rushatgabhane commented Jan 10, 2024

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Bug: For a task, we're showing three dot menu two times.

esh-g commented Jan 10, 2024 • edited Loading

rushatgabhane left a comment

Choose a reason for hiding this comment

esh-g commented Jan 10, 2024

dubielzyk-expensify commented Jan 11, 2024

esh-g commented Jan 12, 2024

esh-g commented Jan 12, 2024

quinthar commented Jan 12, 2024

dubielzyk-expensify commented Jan 14, 2024

esh-g commented Jan 15, 2024

dubielzyk-expensify commented Jan 15, 2024

rushatgabhane commented Jan 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

mountiny commented Jan 16, 2024

quinthar commented Jan 17, 2024

esh-g commented Jan 17, 2024

esh-g commented Jan 17, 2024 • edited Loading

mountiny commented Jan 17, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 18, 2024

OSBotify commented Jan 18, 2024

OSBotify commented Jan 19, 2024

esh-g commented Jan 5, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

esh-g commented Jan 10, 2024 •

edited

Loading

rushatgabhane commented Jan 15, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

esh-g commented Jan 17, 2024 •

edited

Loading