[$250] Expense - Combined report in LHN is always bolded after modifying transaction

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.66-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat with no unsettled expense.
3. Create an expense.
4. Go to combined report.
5. Pin the report to LHN.
6. Note that the report in LHN is not bolded.
7. Go to combined report and modifying any field.
8. Note that LHN is bolded.
9. Go back and forth between other chat and the combined report.
10. Note that the combined report in LHN is still bolded.

Expected Result:

In Step 8, since there is no unread messages in the combined report, the combined report in LHN will not be bolded.

Actual Result:

After modifying transaction details, the combined report in LHN is always bolded.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6462672_1714125466840.RPReplay_Final1714125219.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01471012e33a8b1fcb
• Upwork Job ID: 1783842500724846592
• Last Price Increase: 2024-04-26

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01471012e33a8b1fcb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[mountiny]

This seems like the culprit #40676

[mountiny]

testing a revert

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After modifying transaction details, the combined report in LHN is always bolded.

What is the root cause of that problem?

This is noticeable after #40676, but the root cause is in the back-end, when we OpenReport in the one-transaction-view, it will not update the lastReadTime of the transactionThreadReport.

This also happens for other commands like UpdateMoneyRequestDescription

What changes do you think we should make in order to solve the problem?

Fix the back-end so that when we OpenReport in the one-transaction-view, it will not update the lastReadTime of the transactionThreadReport.

We also need to polish the offline case by calling readNewestAction for transactionThreadReport?.reportID in various places in ReportActionsList and also check isUnread for transactionThreadReport here. Otherwise if the one-transaction-report as unread messages and we go to it in offline mode, the LHN will still be bold.

What alternative solutions did you explore? (Optional)

NA

[mountiny]

@tienifr could we instead in the frontend consider only the report actions for the expense report when comparing the timestamps?

So when we compare the lastReadTime to know if we should show the report as bold/ unread, we will only consider the expense report actions?

[tienifr]

@mountiny Then it will reintroduce this issue #39407.

The reportID is of the expense report, but the content shown is of the transaction thread. So I think it's correct that the "read" status of the one-transaction-view will depend on the transaction thread report and not the expense report.

[mountiny]

Alright, I am going to revert that PR as I have confirmed it fixes this issue and then @nkdengineer please consider this regression in your follow up issue

[tienifr]

So when we compare the lastReadTime to know if we should show the report as bold/ unread, we will only consider the expense report actions?

@mountiny We can do this as a temporary fix if this issue is serious, but IMO we still need to fix the back-end and reintroduce that logic to use the transaction thread.

[mountiny]

Yeah, I assume we need to look into this from the backend perspective too cc @NikkiWines for visibility

Here is a straight revert #41099

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix unread issue in combine report" #41099

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment (Needs manual offer from BZ)

[melvin-bot]

@iwiznia, @akinwale Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@iwiznia, @akinwale 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[iwiznia]

This is not fixed yet, seems the PR is being worked on still

[paultsimura]

@NikkiWines could you please verify the possibility of a BE fix?

Ref: #39407 (comment)

[NikkiWines]

Sorry for the delay - I'll look into implementing a fix for updating the lastReadTime for the transactionThreadReport when we open a one-expense report. Shouldn't be too tricky 🍀

[CortneyOfstad]

Thanks @NikkiWines!

[NikkiWines]

Took a look at this with #42005 checked out as well (with no backend changes), since that modifies the LHN view for one-transaction reports and I'm not able to reproduce the bug.

Screen.Recording.2024-05-20.at.14.46.48.mov

However, I did experience a separate bug involving the unread indicator not consistently working for the one-transaction view (particularly for system messages). I'll see if there's a separate bug report for that.

I guess let's wait for #42005 to be deployed and confirm if the bug still exists on staging / prod and we can go from there

[CortneyOfstad]

Sounds good — thanks @NikkiWines!

[melvin-bot]

@iwiznia, @akinwale, @CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[iwiznia]

@kbecciv can you check if this bug is still present please?

[CortneyOfstad]

Bump @kbecciv ^^^ thanks!

[kbecciv]

@iwiznia @CortneyOfstad Checking

[kbecciv]

Not reproducible

Recording.165.mp4

[CortneyOfstad]

Thanks @kbecciv! Going to close!