Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "Fix unread issue in combine report" #41099

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Apr 26, 2024

Reverts #40676

Fixed Issues

$ #41088
PROPOSAL:

Tests

  1. Go to staging.new.expensify.com
  2. Go to workspace chat with no unsettled expense.
  3. Create an expense. (this could be in DM too)
  4. Go to combined report.
  5. Pin the report to LHN.
  6. Note that the report in LHN is not bolded.
  7. Go to combined report and modifying any field.
  8. Verify the LHN is not bold
  9. Go back and forth between other chat and the combined report.
  10. Verify the combined report is not bold in the LHN
image

@mountiny mountiny self-assigned this Apr 26, 2024
@mountiny mountiny marked this pull request as ready for review April 26, 2024 14:01
@mountiny mountiny requested a review from a team as a code owner April 26, 2024 14:01
@melvin-bot melvin-bot bot removed the request for review from a team April 26, 2024 14:01
Copy link

melvin-bot bot commented Apr 26, 2024

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@danieldoglas danieldoglas merged commit 6913af6 into main Apr 26, 2024
13 of 16 checks passed
@danieldoglas danieldoglas deleted the revert-40676-fix/39407 branch April 26, 2024 14:06
Copy link

melvin-bot bot commented Apr 26, 2024

@danieldoglas looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Apr 26, 2024
@danieldoglas
Copy link
Contributor

Straight revert, no checklist needed.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Apr 26, 2024
[CP Staging] Revert "Fix unread issue in combine report"

(cherry picked from commit 6913af6)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.66-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants