Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert android onLoadStart event and remove cachePath #18997

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hellohublot
Copy link
Contributor

Details

Expensify/react-native-fast-image#5
Upstream has been merged, it has reverted onLoadStart and removed cachePath, so we update the corresponding version

Fixed Issues

$ #16046
$ #16046 (comment)

Tests

  1. Send 1 picture
  2. Send 3 PDF files
  3. Click the picture to preview
  4. Switch between 4 files
  5. When switching to the picture, verify the picture will not always display loading forever
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as others

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
_web.mov
Mobile Web - Chrome
_mobile_chrome.mp4
Mobile Web - Safari
_mobile_safari.mp4
Desktop
_desktop.mov
iOS
_ios.mp4
Android
_android.mp4

@danieldoglas
Copy link
Contributor

PR merged on react-native-fast-image

@hellohublot hellohublot marked this pull request as ready for review May 17, 2023 18:04
@hellohublot hellohublot requested a review from a team as a code owner May 17, 2023 18:04
@melvin-bot melvin-bot bot removed the request for review from a team May 17, 2023 18:04
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

@danieldoglas @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mollfpr
Copy link
Contributor

mollfpr commented May 18, 2023

@hellohublot Could you resolve the conflict? Thanks!

@hellohublot
Copy link
Contributor Author

hellohublot commented May 18, 2023

@danieldoglas @mollfpr Hello, this PR #19021 reverts Expensify/react-native-fast-image to react-native-fast-image.patch, so I can't simply resolve the conflict

We can simply modify react-native-fast-image.patch, but I prefer to use Expensify/react-native-fast-image and avoid using patch.
So we can only revert Expensify/react-native-fast-image@2cc218a, but not all, and then we can continue use Expensify/react-native-fast-image.

Revert pr is ready: Expensify/react-native-fast-image#7

@danieldoglas
Copy link
Contributor

We can modify react-native-fast-image.patch, but I prefer to use Expensify/react-native-fast-image and avoid using patch

@Julesssss @mountiny we've moved out of our own branch for react-native-fast-image. Is that something we want to keep? We had a fix in progress that was counting on us using it.

We can work on the patch, but I don't want to create a third PR in this solution if you're planning on changing anything else for the fix you're working on.

@Julesssss
Copy link
Contributor

Julesssss commented May 19, 2023

Hey @danieldoglas, tbh I'm not sure why I was tagged here. If I had something to do with this library I have completely forgotten about it :D But it sounds like removing our fork is an option here?

@mountiny
Copy link
Contributor

@hellohublot not sure what exactly you meant here. I think if its an option we could update the patch too here. I dont think we make changes to this package that often

@hellohublot
Copy link
Contributor Author

@mountiny @danieldoglas Yep, I'm not sure whether to use a patch or a fork, so asking for reviewer's opinion

So I still recommend using Expensify/react-native-fast-image to avoid using patch, maybe we can wait for Expensify/react-native-fast-image#6 first

@mountiny
Copy link
Contributor

@hellohublot I agree with your reasoning

@danieldoglas I think its worth waiting/ making another Pr for to our fork to get this feature cleaned up

@danieldoglas
Copy link
Contributor

Ok. @hellohublot let's wait until Expensify/react-native-fast-image#6 is merged, then let's go back to our own fork with the changes we've merged in your previous PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants