-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert android onLoadStart event and remove cachePath #18997
base: main
Are you sure you want to change the base?
Revert android onLoadStart event and remove cachePath #18997
Conversation
PR merged on |
@danieldoglas @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@hellohublot Could you resolve the conflict? Thanks! |
@danieldoglas @mollfpr Hello, this PR #19021 reverts We can simply modify Revert pr is ready: Expensify/react-native-fast-image#7 |
@Julesssss @mountiny we've moved out of our own branch for We can work on the patch, but I don't want to create a third PR in this solution if you're planning on changing anything else for the fix you're working on. |
Hey @danieldoglas, tbh I'm not sure why I was tagged here. If I had something to do with this library I have completely forgotten about it :D But it sounds like removing our fork is an option here? |
@hellohublot not sure what exactly you meant here. I think if its an option we could update the patch too here. I dont think we make changes to this package that often |
@mountiny @danieldoglas Yep, I'm not sure whether to use a
So I still recommend using |
@hellohublot I agree with your reasoning @danieldoglas I think its worth waiting/ making another Pr for to our fork to get this feature cleaned up |
Ok. @hellohublot let's wait until Expensify/react-native-fast-image#6 is merged, then let's go back to our own fork with the changes we've merged in your previous PR. |
Details
Expensify/react-native-fast-image#5
Upstream has been merged, it has reverted
onLoadStart
and removedcachePath
, so we update the corresponding versionFixed Issues
$ #16046
$ #16046 (comment)
Tests
Offline tests
QA Steps
Same as others
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
_web.mov
Mobile Web - Chrome
_mobile_chrome.mp4
Mobile Web - Safari
_mobile_safari.mp4
Desktop
_desktop.mov
iOS
_ios.mp4
Android
_android.mp4