Fix: focusing on item by tab key does not work #33265

DylanDylann · 2023-12-19T04:14:29Z

Details

Web - Search - Selected dropdown item with tab key is not opened in Search

Fixed Issues

$ #32388
PROPOSAL: #32388 (comment)

Tests

Login to ND Expensify
Press CTRL+K or click Magnifying glass icon
Select any dropdown item with Tab key
Press Enter key
The dropdown item that is selected by tab key is opened rather than the highlighted item (default first one) with Up&Down keys

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to ND Expensify
Press CTRL+K or click Magnifying glass icon
Select any dropdown item with Tab key
Press Enter key
The dropdown item that is selected by tab key is opened rather than the highlighted item (default first one) with Up&Down keys

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screencast.from.19-12-2023.11.07.11.webm

MacOS: Desktop

Screencast.from.19-12-2023.12.54.26.webm

melvin-bot · 2023-12-19T04:14:34Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2023-12-20T16:27:45Z

src/components/OptionRow.js

@@ -77,6 +77,7 @@ const propTypes = {
    isMultilineSupported: PropTypes.bool,

    style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
+    keyForList: PropTypes.string,


Can you put this above style and provide a comment explaining it function as we do with other props

@alitoshmatov I just updated

alitoshmatov · 2023-12-21T09:03:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

tab-web.mov

MacOS: Desktop

tab-desktop.mov

alitoshmatov

LGTM!

deetergp

Code looks good and test well! As a KB user, I'm a :bigfan:

deetergp · 2023-12-21T19:33:25Z

The Author PR Checklist Job is failing, because we've updated the list since this PR was created. I'm going to go ahead and merge it since the author filled out the original checklist in full.

OSBotify · 2023-12-21T19:37:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-26T00:14:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.16-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator · 2023-12-27T20:39:27Z

src/components/OptionRow.js

@@ -163,6 +166,7 @@ function OptionRow(props) {
            <Hoverable>
                {(hovered) => (
                    <PressableWithFeedback
+                        testID={props.keyForList}


Just noticing that we probably shouldn't have used testID here since that's pretty much specifically used for testing, why didn't we use id or nativeID?

FYI we updated this in #33667

fix focusing on item by tab key does not work

ffa77cb

DylanDylann requested a review from a team as a code owner December 19, 2023 04:14

melvin-bot bot requested review from alitoshmatov and removed request for a team December 19, 2023 04:14

DylanDylann mentioned this pull request Dec 19, 2023

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

Closed

6 tasks

alitoshmatov reviewed Dec 20, 2023

View reviewed changes

fix add comment keyForList

ce0500f

alitoshmatov approved these changes Dec 21, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp December 21, 2023 09:03

deetergp reviewed Dec 21, 2023

View reviewed changes

deetergp approved these changes Dec 21, 2023

View reviewed changes

deetergp merged commit d3adb4f into Expensify:main Dec 21, 2023
15 of 20 checks passed

github-actions bot mentioned this pull request Dec 22, 2023

Deploy Checklist: New Expensify 2023-12-22 #33480

Closed

32 tasks

Beamanator reviewed Dec 27, 2023

View reviewed changes

situchan mentioned this pull request Jan 5, 2024

[HOLD for payment 2024-01-05][$500] Search - Nothing happens when hitting Enter key on the selected user #33654

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: focusing on item by tab key does not work #33265

Fix: focusing on item by tab key does not work #33265

DylanDylann commented Dec 19, 2023 •

edited by deetergp

Loading

melvin-bot bot commented Dec 19, 2023

alitoshmatov Dec 20, 2023

DylanDylann Dec 21, 2023

alitoshmatov commented Dec 21, 2023 •

edited

Loading

alitoshmatov left a comment

deetergp left a comment

deetergp commented Dec 21, 2023

OSBotify commented Dec 21, 2023

OSBotify commented Dec 26, 2023

Beamanator Dec 27, 2023

Beamanator Dec 27, 2023

Fix: focusing on item by tab key does not work #33265

Fix: focusing on item by tab key does not work #33265

Conversation

DylanDylann commented Dec 19, 2023 • edited by deetergp Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 19, 2023

alitoshmatov Dec 20, 2023

Choose a reason for hiding this comment

DylanDylann Dec 21, 2023

Choose a reason for hiding this comment

alitoshmatov commented Dec 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

alitoshmatov left a comment

Choose a reason for hiding this comment

deetergp left a comment

Choose a reason for hiding this comment

deetergp commented Dec 21, 2023

OSBotify commented Dec 21, 2023

OSBotify commented Dec 26, 2023

Beamanator Dec 27, 2023

Choose a reason for hiding this comment

Beamanator Dec 27, 2023

Choose a reason for hiding this comment

DylanDylann commented Dec 19, 2023 •

edited by deetergp

Loading

alitoshmatov commented Dec 21, 2023 •

edited

Loading