-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate KYCWall component #33714
[TS migration] Migrate KYCWall component #33714
Conversation
f125763
to
5068db1
Compare
5068db1
to
570e0a4
Compare
# Conflicts: # src/libs/actions/PaymentMethods.ts # src/types/onyx/WalletTerms.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Conflicts: # src/types/onyx/WalletTerms.ts
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25126 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
@Julesssss all yours! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One TS issue remains:
Error: src/libs/actions/Wallet.ts(92,40): error TS2322: Type 'string' is not assignable to type 'ValueOf<{ readonly REPORT: "REPORT"; readonly ENABLE_WALLET: "ENABLE_WALLET"; readonly TRANSFER_BALANCE: "TRANSFER_BALANCE"; }> | null | undefined'.
@Julesssss, I've fixed the issue. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.27-0 🚀
|
coming from #34257, I have one issue with event type in App/src/components/KYCWall/BaseKYCWall.tsx Line 149 in 991a4e2
So I don't think it'll be compatible with onPress of MenuItem or Button. Wdyt? @ruben-rebelo @blazejkustra |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.27-1 🚀
|
coming from #33866 What was the point of swapping the parameters? App/src/components/KYCWall/BaseKYCWall.tsx Line 206 in 56fb814
|
@ZhenjaHorbach The parameter swap was done because on the initial work the source parameter was required but after the migration was completed it didn't made sense anymore to have it as required, this part can be reverted as it is a left-over. |
@ZhenjaHorbach @tienifr I've created a Draft PR for this changes. Here is the link: #34870 |
Ah this seems like it broke paying IOU reports |
@Julesssss @rushatgabhane PRS touching the wallet payment flows should ideally be labelled with internalQA as the wallet payment flow cannot be tested otherwise easily, not by the contributors at least |
Ah thanks, I forgot that the InternalQa label works for the App repo 👍 |
Details
[TS migration] Migrate KYCWall component
Fixed Issues
$ #25126
PROPOSAL: N/A
Tests
Offline tests
Same as Tests section
QA Steps
Same as Tests section
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop