Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript #36314

Merged
merged 71 commits into from
Apr 11, 2024

Conversation

eucool
Copy link
Contributor

@eucool eucool commented Feb 12, 2024

Details

Fixed Issues

$ #32000
PROPOSAL: #32000 (comment)

Tests

Same as QA step

  • Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

  1. Go to FAB/workspace chat/1:1
  2. Click on request money
  3. click on scan
  4. Click photo (Native)/ upload file (MacOS/ safari)
    The photo should be clicked successfully and we should be able to go to the confirmation page
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: mWeb Safari
Android: mWeb Chrome
iOS: Native
Android: Native
MacOS: Desktop
MacOS: Chrome / Safari

@eucool eucool requested a review from a team as a code owner February 12, 2024 08:44
@melvin-bot melvin-bot bot requested review from akinwale and removed request for a team February 12, 2024 08:44
Copy link

melvin-bot bot commented Feb 12, 2024

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@kubabutkiewicz
Copy link
Contributor

Hi @codinggeek2023 can you fix ts check, lint and do a PR author checklist?

@eucool
Copy link
Contributor Author

eucool commented Feb 12, 2024

hello @kubabutkiewicz , thanks for responding, i will do it ASAP, i am getting some error while converting a HOC into typescript, can you please help me out over here :), i'll comment over the HOC

@eucool
Copy link
Contributor Author

eucool commented Feb 13, 2024

Hello @kubabutkiewicz , please review the PR when you find time :), i have pushed the latest changes

@kubabutkiewicz
Copy link
Contributor

@codinggeek2023 hi I will review it today, can you also fill the PR Author Checklist?

@kubabutkiewicz
Copy link
Contributor

@codinggeek2023 there is still typescript check failing and also a lint

Copy link

melvin-bot bot commented Apr 9, 2024

We did not find an internal engineer to review this PR, trying to assign a random engineer to #32000 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot melvin-bot bot requested a review from MonilBhavsar April 9, 2024 11:43
// If the report is iou or expense report, we should get the chat report to set participant for request money
const chatReport = ReportUtils.isMoneyRequestReport(report) ? ReportUtils.getReport(report.chatReportID) : report;
const chatReport = ReportUtils.isMoneyRequestReport(report) ? ReportUtils.getReport(report?.chatReportID) : report;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is optional chaining really required for chatReportID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function must be used in a bunch of places so not to break any functionality here :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I would assume chatReportID is always set. But it's fine

src/pages/iou/ReceiptDropUI.tsx Show resolved Hide resolved
src/pages/iou/ReceiptDropUI.tsx Outdated Show resolved Hide resolved
if (!validateReceipt(file)) {
return;
}

// Store the receipt on the transaction object in Onyx
// On Android devices, fetching blob for a file with name containing spaces fails to retrieve the type of file.
// So, let us also save the file type in receipt for later use during blob fetch
IOU.setMoneyRequestReceipt(transactionID, file.uri, file.name, action !== CONST.IOU.ACTION.EDIT, file.type);
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
IOU.setMoneyRequestReceipt(transactionID, file?.uri ?? '', file.name || '', action !== CONST.IOU.ACTION.EDIT, file.type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use null coalesce here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks! I wonder if || was added for any specific case where we could not use ??

@blazejkustra
Copy link
Contributor

@codinggeek2023 Typecheck is failing, please have a look

@eucool
Copy link
Contributor Author

eucool commented Apr 9, 2024

Fixed the typecheck, i guess one more component was migrated to TS so the error again, otherwise the tests were passing :) thanks @blazejkustra

@eucool
Copy link
Contributor Author

eucool commented Apr 9, 2024

@MonilBhavsar can you please put a ready to build label here? This is the camera component and it would be good if we test it in ADHOC build on physical devices too

@MonilBhavsar
Copy link
Contributor

Good idea! There are conflicts now. Can you please resolve it. I can generate a build then

@eucool
Copy link
Contributor Author

eucool commented Apr 10, 2024

Fixed the conflicts, letss build @MonilBhavsar 💪

Copy link
Contributor

@fabioh8010
Copy link
Contributor

Build is ready, what are next steps here @codinggeek2023 @MonilBhavsar ? Need any help?

@eucool
Copy link
Contributor Author

eucool commented Apr 11, 2024

Let's merge this one, I was not able to test on Native IOS it says integrity could not be verified but should work fine

@MonilBhavsar MonilBhavsar merged commit 9e10604 into Expensify:main Apr 11, 2024
15 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.63-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants