[No QA] Card settings page

[koko57]

Details

Fixed Issues

$ #44311
$ #44312
$ #44313
PROPOSAL: -

Tests

PREREQUISITES: Comment out AccessOrNotFoundWrapper in WorkspaceCardSettingsPage, WorkspaceSettlementAccountPage and WorkspaceSettlementFrequencyPage

1. WEB/mWEB: Go to settings/workspaces/[yourWorkspace]. In the browser add expensify-card/settings to the URL.
   MOBILE: (with simulator open and project build) in the terminal type npx uri-scheme open new-expensify://settings/workspaces/[workspaceId]/expensify-card/settings --ios to open on iOS, npx uri-scheme open new-expensify://settings/workspaces/[workspaceId]/expensify-card/settings --android to open on android.
   DESKTOP: with the desktop app open, in the browser type https://staging.new.expensify.com/settings/workspaces/[workspaceId]/expensify-card/settings, when the prompt to open the app will be displayed, open the app
2. Verify that the settings page displays correctly with two items.
3. Go to Frequency setting, verify that options are displayed correctly
4. Go to Account setting, verify that options are displayed correctly

🚨 NOTE: for now I'm not filtering out eligible accounts for easier testing. It will be done when integrating with the backend. I also haven't disabled Frequency menu item to make it possible to check both Daily and Monthly state

• Verify that no errors appear in the JS console

Offline tests

QA Steps

n/a

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

Why not ?? nullish operator here, any specific reason ?

[koko57]

if allowDebit would be false it would return false and wouldn't check for the type. We could have false for allowDebit but type would be fine, but we would get false incorrectly

[mountiny]

Could we get around this? I believe that any eslnt rule disable means that react-compiler does not process this file, we should try to avoid adding any eslint-disable to new code

[koko57]

@allgandalf fixed the navigation

[allgandalf]

Bug

On frequency page, the highlight doesn't move to the newly selected value

Screen.Recording.2024-07-19.at.3.44.39.PM.mov

[allgandalf]

### Bug

The animation is not smooth if we go back from frequency/bank account settings page to card setting page, (for comparison, observe the animation if we go back from card settings to card page, that is smooth but not for the frequency page)

https://github.com/user-attachments/assets/88c25007-8921-42db-a9f0-373e5b22e795

EDIT: I just checked with other pages, it is the same behaviour we shouldn't do anything here

[koko57]

Bug

On frequency page, the highlight doesn't move to the newly selected value

Screen.Recording.2024-07-19.at.3.44.39.PM.mov

@allgandalf - this is something that has not been implemented for this component. @VickyStash added it to https://github.com/Expensify/App/pull/45601/files, we can incorporate these changes in a follow-up (when connecting to the BE) or probably this would work out of the box

[allgandalf]

All good then!

[allgandalf]

NAB: When i click on learn more nothing happens really, is it for future implementation @koko57 ?

[allgandalf]

This tests well on all platforms, the bug i found was mentioned here, would actually be solved when we implement the BE, I will keep an eye out because that bug is very much a blocker to me if i cannot shift the focus on options, rest assured, we can merge this one before the week closes, thanks for the back and forth @koko57!

[koko57]

NAB: When i click on learn more nothing happens really, is it for future implementation @koko57 ?

yep, the doc is being worked on, once it's done we'll get a proper url to link to

[trjExpensify]

Great! It would be awesome to get this merged today, as it's the last PR left in Phase 2. 🎉

[mountiny]

Changes look good to me, thank you @koko57 and @allgandalf for quick testing.

This is now all ready for @MariaHCD

[MariaHCD]

LGTM! Just one comment

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[dangrous]

probably just got the ping but looks like the "Reconciliation account" link isn't working properly. Not sure if this is the only issue but I am not sure it's accounting for if you don't have a reconciliation account - or an accounting integration - yet

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅