-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization #90
Merged
Merged
Optimization #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DepthBufferLiDAR script
Add noise model to depth cam
Create PC2Msg Publisher for DepthBufferLiDAR
Add TF scripts
This was
linked to
issues
Jan 5, 2024
Closed
Fix pointcloud noise calc
RyodoTanaka
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the update.
And confirmed all scripts are working.
So, I approve this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
従来はPublisherクラスがSensor-Serializer間のデータの受け渡しを行っていた
これにより、DepthCameraとLiDARの間で点群メッセージのSerializer, Publisherを共通化した
Changes Overview
Namespace Refactoring
Modified "Visualizer" classes to operate in event-driven
Modified "Serializer" classes to have direct access to each "Sensor" class
Modified "Serializer", "Publisher" classes to correspond to the type of message they handled, not to the sensor
Accelerated visualization of point clouds using GPU instances
Added "ScanPatternGenerator" class to generate "ScanPattern" scriptable object
DepthBuffer method now available for all scan patterns
Now VLS-128 runs at 60 FPS 😎
The following LiDAR scan patterns were added