-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-1939, GPII-2404 - Device Reporter to report screen resolutions #134
base: master
Are you sure you want to change the base?
Conversation
…creen resolutions - Modified the display settings handler to get both the current and all available screen resolutions in one JSON object. - Refactored the handler into a fluid component. - Updated the unit tests in light of the above.
…creen resolutions Reverted getScreenResolution() to return an object with just width and height, but modified getImpl() to add a "screen-resolution" property.
…resolutions Better way to set current screen resolution return value. Also, cleaned up some comments.
…resolutions Removed unused functions.
Added machinery for providing a Linux/GNOME Platform Reporter that uses the Windows display settings handler to report all screen resolutions. Note: includes code from pull request for GPII-2404, "Windows display settings handler should report all available screen resolutions".
Fixed bug so that GPII finds the Windows context platform reporter.
ok to test |
CI job passed. |
CI job passed. |
Modified PlatformReporter to remove the "dmPels" prefix on width and height as returned by the display settings handler.
CI job passed. |
Modifed the "getAllScreenResolutions" to drop the "dmPels" prefix.
- Merge branch 'GPII-2404' into GPII-1939_GPII-2404 - Since the DisplaySettingsHandler removes the "dmPels" prefix when returning the available screen resolutions, modified the PlatformReporter to simply relay the information as given.
CI job passed. |
CI job passed. |
CI job passed: https://ci.gpii.net/job/windows-tests/445/ |
CI job failed: https://ci.gpii.net/job/windows-tests/453/ |
Modified to reference the version of universal just prior to incorporating Kasper's GPII-1230 code, which introduced functionality not yet implemented in the windows repository.
CI job failed: https://ci.gpii.net/job/windows-tests/456/ |
ok to test |
1 similar comment
ok to test |
CI job failed: https://ci.gpii.net/job/windows-tests/457/ |
CI job failed: https://ci.gpii.net/job/windows-tests/458/ |
ok to test |
CI job passed: https://ci.gpii.net/job/windows-tests/459/ |
Includes latest changes from GPII master branch.
CI job passed: https://ci.gpii.net/job/windows-tests/471/ |
Merged in upstream master branch.
…esolutions Mergeed upstream master GPII branch, including changes from GPII-2404.
CI job passed: https://ci.gpii.net/job/windows-tests/494/ |
ok to test |
CI job failed: https://ci.gpii.net/job/windows-tests/513/ |
ok to test |
CI job failed: https://ci.gpii.net/job/windows-tests/520/ |
ok to test |
CI job failed: https://ci.gpii.net/job/windows-tests/523/ |
Stop acceptance tests crashing.
CI job passed: https://ci.gpii.net/job/windows-tests/528/ |
CI job passed: https://ci.gpii.net/job/windows-tests/533/ |
Windows specific code for Device Reporter to report screen resolutions.