Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-1939, GPII-2404 - Device Reporter to report screen resolutions #134

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

klown
Copy link
Member

@klown klown commented Aug 4, 2017

Windows specific code for Device Reporter to report screen resolutions.

klown added 10 commits May 5, 2017 14:52
…creen resolutions

- Modified the display settings handler to get both the current and all available
screen resolutions in one JSON object.
- Refactored the handler into a fluid component.
- Updated the unit tests in light of the above.
…creen resolutions

Reverted getScreenResolution() to return an object with just width and height, but
modified getImpl() to add a "screen-resolution" property.
…resolutions

Better way to set current screen resolution return value.  Also, cleaned up some
comments.
Added machinery for providing a Linux/GNOME Platform Reporter that
uses the Windows display settings handler to report all screen resolutions.

Note:  includes code from pull request for GPII-2404, "Windows display
settings handler should report all available screen resolutions".
Fixed bug so that GPII finds the Windows context platform reporter.
@klown
Copy link
Member Author

klown commented Aug 4, 2017

ok to test

@gpii-bot
Copy link

gpii-bot commented Aug 4, 2017

CI job passed.

@klown klown changed the title GPII-2939, GPII-2404 GPII-1939, GPII-2404 Aug 24, 2017
@gpii-bot
Copy link

CI job passed.

Modified PlatformReporter to remove the "dmPels" prefix on width
and height as returned by the display settings handler.
@gpii-bot
Copy link

CI job passed.

Modifed the "getAllScreenResolutions" to drop the "dmPels" prefix.
- Merge branch 'GPII-2404' into GPII-1939_GPII-2404
- Since the DisplaySettingsHandler removes the "dmPels" prefix when
returning the available screen resolutions, modified the PlatformReporter
to simply relay the information as given.
@gpii-bot
Copy link

CI job passed.

@gpii-bot
Copy link

CI job passed.

@gpii-bot
Copy link

gpii-bot commented Apr 2, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/445/

@gpii-bot
Copy link

gpii-bot commented Apr 5, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/453/

Modified to reference the version of universal just prior to
incorporating Kasper's GPII-1230 code, which introduced functionality
not yet implemented in the windows repository.
@gpii-bot
Copy link

gpii-bot commented Apr 6, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/456/

@klown
Copy link
Member Author

klown commented Apr 6, 2018

ok to test

1 similar comment
@klown
Copy link
Member Author

klown commented Apr 6, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Apr 6, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/457/

@gpii-bot
Copy link

gpii-bot commented Apr 6, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/458/

@klown
Copy link
Member Author

klown commented Apr 6, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Apr 6, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/459/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/471/

klown added 2 commits May 17, 2018 13:32
…esolutions

Mergeed upstream master GPII branch, including changes from GPII-2404.
@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/494/

@klown
Copy link
Member Author

klown commented Jun 4, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jun 4, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/513/

@klown
Copy link
Member Author

klown commented Jun 5, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jun 5, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/520/

@klown
Copy link
Member Author

klown commented Jun 6, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jun 6, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/523/

@gpii-bot
Copy link

gpii-bot commented Jun 7, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/528/

@gpii-bot
Copy link

gpii-bot commented Jun 8, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/533/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants