Twix CompletionEdit #1478
Merged
Twix CompletionEdit #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleflb
force-pushed
the
twix-completion
branch
from
4fbbcb2 to
72361df
Compare
oleflb
force-pushed
the
twix-completion
branch
from
3b66f73 to
fb626b7
Compare
rmburg
force-pushed
the
twix-completion
branch
from
7c943d3 to
672ffc9
Compare
rmburg
reviewed
Nov 30, 2024
rmburg
reviewed
Dec 3, 2024
rmburg
reviewed
Dec 4, 2024
|
Zweig muss neu geerdet werden 🌳 |
oleflb
force-pushed
the
twix-completion
branch
from
549d55f to
6311e62
Compare
Ist neu geerdet |
|
Resolve remaining comments when read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Fix twix completion edit since its broken on main.
I like the idea of trying to implement generally usable widgets in a separate crate from twix so that they can be used in other tools as well. Therefore I rewrote the completion edit to be less dependent on what is currently searched.
The fuzzy finder is replaced by the one from helix since it is way faster, besides that, the matching algorithm now is started only when the user input changed, not every frame.
The SegmentedControl widget is another generally usable widget I implemented some time ago for another tool and now I wanted to be available for twix as well.
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test