vendored lua #1530
Merged
vendored lua #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
schmidma
previously approved these changes
Dec 11, 2024
oleflb
force-pushed
the
vendored-lua-2
branch
from
6927347 to
7cac813
Compare
schmidma
previously approved these changes
Dec 11, 2024
|
@oleflb ping, the CI is unhappy with your |
oleflb
force-pushed
the
vendored-lua-2
branch
from
7cac813 to
34fde58
Compare
oleflb
force-pushed
the
vendored-lua-2
branch
from
34fde58 to
deacc37
Compare
|
@schmidma Fixed now. Newer versions of cargo are setting the lockfile version to 4 by default and it seems like the cargo version in the sdk cannot handle that |
schmidma
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
This is a main compatible version of #1072 by @h3ndrk
When compiling mlua unvendored, you need to install Lua on your system. Especially under Windoof, this can be painful, therefore we want to switch to a vendored version.
Does not heilmachen #1071 completely because we still need further fixes because we are still using symlinks which are not supported under Windoof.
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test