-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow controller & misc #12924
Flow controller & misc #12924
Conversation
@@ -26,6 +25,7 @@ namespace realdds { | |||
|
|||
class dds_topic; | |||
class dds_publisher; | |||
class dds_participant; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
// Separate one field from the previous: | ||
// os << field::separator << "whatever"; | ||
// If any indent is set, this will be on a separate line! | ||
static std::ostream & separator( std::ostream & ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The separator/value notation is not that clear. Maybe use key/value or name/value notation
Need ability to use flow-controllers in DDS, to limit data rates. This is the prep work, including everything but the actual creation and usage of the flow-controllers (pending changes from eProsima):
dds_topic_writer
,dds_topic_reader
, anddds_participant
qos overridestopic-send
and addtopic-sink
utilitiesPlus some misc stuff:
make_less_screamy
use a more generic algorithmword_format
that can do genericdash_case
conversionsrsutils::ios
namespace for ios manipulationsios::field
andios::indent
, to make structure output to stream more standardizedformat_conversion
, per Nir's requestrecommended-filters
instream-options
Serialization looks like this: