Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pain immunity to some things that should prolly have it anyways #4553

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

Absolucy
Copy link
Collaborator

@Absolucy Absolucy commented Dec 12, 2024

About The Pull Request

This adds full pain immunity to the following things:

  • Florida Man
    • also kinda cleaned up florida man code in general
  • Juggernaut Suit
  • Ascended rust heretics (only while on rust)
  • Zombies
  • Nightmares
    • Zombies and nightmares already had TRAIT_NO_PAIN_EFFECTS, I just added the other traits related to negating pain, just to make 100% sure.
  • Bloodsuckers
    • Fortitude provides pain immunity - it already had TRAIT_ANALGESIA, this is just making sure it fully covers everything.
    • Torpor fully heals all pain now, as it does with most other damage and effects.
    • The Sol debuff now adds a 50% increase in pain for bloodsuckers when they're out during Sol.

In addition, ascended blade heretics will heal their pain and reduce their shock buildup when their lifesteal triggers (upon attacking a living mob with their blade)

Why It's Good For The Game

Pain is still not really fully accounted for by many things (latest example being #4391), so this should help alleviate that somewhat.

also i did clean up some code + add some checks to hopefully reduce the chances of runtime errors

Changelog

🆑
fix: Zombies and nightmares should now properly be immune to pain.
balance: The Cybersun Juggernaut suit now provides the wearer with immunity to pain and its effects.
balance: Florida Man is now immune to pain and its effects.
balance: Ascended rust heretics, while on rusted tiles, are immune to pain and its effects.
balance: Ascended blade heretic lifesteal now heals pain and reduce shock buildup.
balance: Bloodsuckers are now fully immune to pain and its effects while Fortitude is active.
balance: Bloodsuckers now heal off pain while in torpor.
balance: Bloodsuckers gain a 50% increase in pain from the debuff applied while out during Sol.
code: Added some additional sanity checks to pain code, to prevent potential runtime errors.
/:cl:

@Absolucy Absolucy added the Balance perfectly balanced as all things should be label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance perfectly balanced as all things should be
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant