-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pain immunity to some things that should prolly have it anyways #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2024
… out during Sol. Also added some sanity checks.
This was referenced Dec 16, 2024
Closed
This was referenced Dec 18, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This adds full pain immunity to the following things:
TRAIT_NO_PAIN_EFFECTS
, I just added the other traits related to negating pain, just to make 100% sure.TRAIT_ANALGESIA
, this is just making sure it fully covers everything.In addition, ascended blade heretics will heal their pain and reduce their shock buildup when their lifesteal triggers (upon attacking a living mob with their blade)
Why It's Good For The Game
Pain is still not really fully accounted for by many things (latest example being #4391), so this should help alleviate that somewhat.
also i did clean up some code + add some checks to hopefully reduce the chances of runtime errors
Changelog
🆑
fix: Zombies and nightmares should now properly be immune to pain.
balance: The Cybersun Juggernaut suit now provides the wearer with immunity to pain and its effects.
balance: Florida Man is now immune to pain and its effects.
balance: Ascended rust heretics, while on rusted tiles, are immune to pain and its effects.
balance: Ascended blade heretic lifesteal now heals pain and reduce shock buildup.
balance: Bloodsuckers are now fully immune to pain and its effects while Fortitude is active.
balance: Bloodsuckers now heal off pain while in torpor.
balance: Bloodsuckers gain a 50% increase in pain from the debuff applied while out during Sol.
code: Added some additional sanity checks to pain code, to prevent potential runtime errors.
/:cl: