-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports new body cameras & Jammers #4661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitsunemitsu
added
the
Refactor/Rework
Completely redoing a larger thing / recoding a thing
label
Dec 24, 2024
Absolucy
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good at a cursory glance, with one minor nitpick
monkestation/code/modules/clothing/suit_accessories/bodycamera.dm
Outdated
Show resolved
Hide resolved
This was referenced Dec 27, 2024
Open
This was referenced Dec 27, 2024
Open
Co-authored-by: Lucy <[email protected]>
This was referenced Dec 28, 2024
This was referenced Dec 29, 2024
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
* Ports new body cameras & Jammers * oops * Update monkestation/code/modules/clothing/suit_accessories/bodycamera.dm Co-authored-by: Lucy <[email protected]> * Update bodycamera.dm * Update bodycamera.dm * Update bodycamera.dm --------- Co-authored-by: Lucy <[email protected]>
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#87149 - Which gives Radio jammers a secondary ability of being able to shut down any radios & body cameras on specific targets within a 7 tile radius.
Ports fulpstation/fulpstation#1273 - Which reworks body cameras, explained below
Ports fulpstation/fulpstation#1299 - Some fixes and adds the interaction between body cameras and radio jammers & EMPs
Before:
Body cameras can be installed into specific security oversuits
You need to manually swipe an ID to turn it on, and it only stays on as long as the suit remains on you. Once it's off, it's gone.
Jammers and EMPs have no effect, as long as the suit remains on the officer, the camera will remain on.
After:
Body cameras can be installed into any vests, giving a visible overlay to display a body camera is on them.
If you're wearing an ID at the time of installation, you don't need to turn your camera on. Otherwise, business as usual.
The camera will remain until it is disabled (swiping any ID, radio jammer) which shows static to anyone attempting to watch it over cameras, or destroyed (screwdriver uninstallation, destroying the vest, EMP) which will remove it from the camera list entirely.
Feel free to take your vest off, have several cameras at once, etc. They will remain visible.
This could perhaps be reverted if body cameras were the only reported issue here 8b0ec02
Why It's Good For The Game
Makes body cameras a little less bad to handle, while also making them work better and without the shitcode that it was previously.
Gives antagonists to know when someone with a camera is watching and gives tools to counter it, while security gets cameras that works more consistently and without having to turn the camera on every single time you take it off, and can put it on whatever costume they want to wear.
As for Jammers, as explained in the PR where I'm porting this from, they are currently very weak and sometimes even go against stealth since you're affecting so many people at once. This targeted attack gives more stealth options and specific individual targeting, with the bonus that we can add this as something that affects body cameras.
Changelog
🆑 SmArtKar & JohnFulpWillard
balance: Body cameras no longer shut off when you take the suit off, and can be equipped to any vest, though they now visibly show up on any vest they are equipped to. They can also now be EMP'ed to remove it from the camera net entirely.
balance: Radio jammers can remotely turn off radios/body cameras on anyone in a 7 tile radius by clicking on them. Default behavior is now on Right-click.
balance: Headsets now don't talk over the radio by default with the microphone on, the microphone now instead decides whether the headset can be used to speak over the radio at all (this is what radio jammers turn off to prevent you from speaking over comms).
/:cl: