Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CLI over to typer, change command to "anglerfish run" #81

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Switch CLI over to typer, change command to "anglerfish run" #81

merged 8 commits into from
Apr 25, 2024

Conversation

remiolsen
Copy link
Member

@remiolsen remiolsen commented Apr 15, 2024 •
edited
Loading

Closes #61
Closes #82

mashehu
mashehu reviewed Apr 15, 2024
View reviewed changes
anglerfish/__main__.py Outdated Show resolved Hide resolved
@remiolsen remiolsen changed the title Switch CLI over to typer Switch CLI over to typer, change command to "anglerfish run" Apr 17, 2024
@remiolsen remiolsen marked this pull request as ready for review April 17, 2024 10:50
@remiolsen remiolsen requested a review from alneberg April 17, 2024 10:51
alneberg
alneberg approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and seems to work according to my shallow testing.

@remiolsen remiolsen merged commit 249360c into master Apr 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu left review comments

@alneberg alneberg alneberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add the anglerfish ascii to the command line output :P Convert to click CLI
3 participants
@remiolsen @alneberg @mashehu