switch-to-configuration: Better handling of socket-activated units #359724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if any unit had a socket associated with it, stc-ng counted it as "socket-activated", meaning that the unit would get stopped and the socket get restarted. That can wreak havoc on units like systemd-udevd and systemd-networkd. Instead, let units set the new flag notSocketActivated, which sets a boolean on the unit indicating to stc-ng that the unit wants to be treated like any other non-socket-activated unit instead. That will stop/start or restart these units on upgrades, without unnecessarily tearing down any machinery that the system needs to run.
github-actions
bot
added
6.topic: nixos
nix-owners
bot
requested review from
aanderse,
arianvp,
ElvishJerricco and
flokli
|
I believe this doesn't 100% entirely resolve the issue: While on one machine, explicitly starting udevd & networkd again did allow the switch to go through without issue, on another, the original problem occurred: tailscale0 turned pending (from unmanaged). Maybe the logic around stopping/starting these critical services is wrong entirely? |
|
Can you please implement the perl side of this as well? We will need to have both prior to merge. |
Added, thanks for the note! |
antifuchs
changed the title
fpletz
approved these changes
Nov 30, 2024
wegank
added
the
12.approvals: 1
ElvishJerricco
requested changes
Dec 8, 2024
Updated, thanks for the pointer! |
github-actions
bot
added
the
8.has: documentation
wegank
removed
the
12.approvals: 1
phaer
approved these changes
Jan 4, 2025
ElvishJerricco
approved these changes
Jan 4, 2025
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if any unit had a socket associated with it, stc-ng counted it as "socket-activated", meaning that the unit would get stopped and the socket get restarted. That can wreak havoc on units like systemd-udevd and systemd-networkd.
Instead, let units set the new flag notSocketActivated, which sets a boolean on the unit indicating to stc-ng that the unit wants to be treated like any other non-socket-activated unit instead. That will stop/start or restart these units on upgrades, without unnecessarily tearing down any machinery that the system needs to run.
This addresses what @ElvishJerricco and I thought was a systemd bug (systemd/systemd#35371) but is really a bug in how socket-activated services are handled in stc (and -ng).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.