houdini: fix fhsenv version #363168
Merged
houdini: fix fhsenv version #363168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
getchoo
approved these changes
Dec 9, 2024
getchoo
added
the
12.approvals: 1
Pandapip1
approved these changes
Dec 10, 2024
Stunkymonkey
force-pushed
the
houdini-fhsenv-version
branch
from
b473614 to
86731c1
Compare
Pandapip1
approved these changes
Dec 10, 2024
getchoo
approved these changes
Dec 11, 2024
getchoo
added
12.approvals: 2
wrvsrx
added a commit
to wrvsrx/nixpkgs
that referenced
this pull request
Jan 3, 2025
After NixOS#363168, houdini can't run anymore becase of infinite loop in shell script. `extraInstallCommands` of NixOS#363168 gives such script `$out/bin/houdini`: ```bash \#!${stdenv.shell} exec $out/bin/houdini ${unwrapped}/bin/houdini "$@" ``` This script exec itself infinitely.
This was referenced Jan 3, 2025
|
this broke the package and introduced infinite recursion in wrappers. |
wrvsrx
added a commit
to wrvsrx/nixpkgs
that referenced
this pull request
Jan 4, 2025
After NixOS#363168, houdini can't run anymore becase of infinite loop in shell script. `extraInstallCommands` of NixOS#363168 gives such script `$out/bin/houdini`: ```bash \#!${stdenv.shell} exec $out/bin/houdini ${unwrapped}/bin/houdini "$@" ``` This script exec itself infinitely.
I really don't see why that would be the case. Would you mind providing me with derivations that are failing? |
|
no build is failing - the main binary is now just running itself instead of running the wrapped binary because of a name collision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #336576
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.