houdini: make houdini run again

[wrvsrx]

After #363168, houdini can't run anymore becase of infinite loop in shell script. extraInstallCommands of #363168 gives such script $out/bin/houdini:

\#!${stdenv.shell}
exec $out/bin/houdini ${unwrapped}/bin/houdini "$@"

This script exec itself infinitely.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[lucasew]

Can you add a versionCheckHook?

[wrvsrx]

I'm not sure how to add versionCheckHook to buildFHSEnv, can you give a rough example?

[lucasew]

I'm not sure how to add versionCheckHook to buildFHSEnv, can you give a rough example?

I never tried tbh. If buildFHSEnv passthru the arguments to mkDerivation somehow it would be basically the same as it's done everywhere else.

[wrvsrx]

@lucasew buildFHSEnv use runCommandLocal to create the final (executable) derivation, I don't know how to add versionCheckHook into that.

[lucasew]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370461

[lucasew]

@lucasew buildFHSEnv use runCommandLocal to create the final (executable) derivation, I don't know how to add versionCheckHook into that.

Try to pass it as buildFHSEnv is mkDerivation. If it doesn't show the check version message then let it the way it is and let me know.

[wrvsrx]

Add versionCheckHook to nativeBuildInputs and set doInstallCheck = true make Using versionCheckHook appears in nix log .#houdini.

However, nix eval .#houdini.doInstallCheck gives false, which means also hook is added, doInstallCheck is not passed to the final derivation.

[pedohorse]

I personally like this change now.
But there are more knowing people who may comment of what would be the most "this-is-the-way" way

[wrvsrx]

I'll want for your decision.

[Pandapip1]

LGTM. If you really want a version test, you could use passthru.tests / testers.testVersion

[wrvsrx]

LGTM. If you really want a version test, you could use passthru.tests / testers.testVersion

Maybe I can investigate how to do that and add it in another PR. Maybe currently fixing the package is more urgent than adding the test?

[lucasew]

LGTM. If you really want a version test, you could use passthru.tests / testers.testVersion

Maybe I can investigate how to do that and add it in another PR. Maybe currently fixing the package is more urgent than adding the test?

I agree