Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShapeCompletion Action #52

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Add ShapeCompletion Action #52

merged 4 commits into from
Jun 10, 2024

Conversation

chancecardona
Copy link
Contributor

@chancecardona chancecardona commented May 30, 2024

Resolves 7586

@chancecardona chancecardona self-assigned this May 30, 2024
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a draft, but LGTM as-is. I can give another review if things change based on other related work.

Comment on lines -5 to +6
<author email="sebastian.castro@picknik.ai">Sebastian Castro</author>
<maintainer email="sebastian.castro@picknik.ai">Sebastian Castro</maintainer>
<author email="support@picknik.ai">MoveIt Pro maintainer</author>
<maintainer email="support@picknik.ai">MoveIt Pro maintainer</maintainer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel comfortable putting your name/email here, I think that's fine

@chancecardona
Copy link
Contributor Author

@adlarkin thoughts on pointcloud vs point_cloud?

@chancecardona chancecardona marked this pull request as ready for review June 6, 2024 02:00
@adlarkin
Copy link
Contributor

adlarkin commented Jun 6, 2024

I think pointcloud (what you have) is fine!

@EzraBrooks EzraBrooks merged commit a7d6dc1 into main Jun 10, 2024
2 checks passed
@EzraBrooks EzraBrooks deleted the shape-completion-action branch June 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants