Part F of transition to support modernize-use-default-member-init #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Two general comments:
- Let's leave the two 3rdparty files in recognition unchanged for now
- Please don't do any formatting changes (e.g. whitespace changes) in this PR. Let's limit this PR to the clang-tidy changes. Only exception would be formatting changes required by the
Formatting Check code formattingCI job, which might for example require a specific formatting if you change something inregistration
I ran |
|
The CI calls the formatting script, which applies clang-format to certain modules. We add new modules there when no open pull requests in those modules exist. |
larshg
reviewed
Oct 3, 2023
recognition/include/pcl/recognition/impl/ransac_based/simple_octree.hpp
Outdated
Show resolved
Hide resolved
larshg
reviewed
Oct 3, 2023
registration/include/pcl/registration/correspondence_rejection_var_trimmed.h
Outdated
Show resolved
Hide resolved
larshg
reviewed
Oct 3, 2023
larshg
reviewed
Oct 3, 2023
mvieth
reviewed
Oct 4, 2023
registration/include/pcl/registration/default_convergence_criteria.h
Outdated
Show resolved
Hide resolved
mvieth
reviewed
Oct 4, 2023
registration/include/pcl/registration/correspondence_rejection_poly.h
Outdated
Show resolved
Hide resolved
mvieth
reviewed
Oct 5, 2023
mvieth
reviewed
Oct 14, 2023
mvieth
reviewed
Oct 14, 2023
registration/include/pcl/registration/correspondence_rejection.h
Outdated
Show resolved
Hide resolved
mvieth
reviewed
Oct 16, 2023
registration/include/pcl/registration/transformation_estimation_lm.h
Outdated
Show resolved
Hide resolved
registration/include/pcl/registration/transformation_estimation_point_to_plane_weighted.h
Outdated
Show resolved
Hide resolved
registration/include/pcl/registration/correspondence_rejection.h
Outdated
Show resolved
Hide resolved
mvieth
approved these changes
Oct 21, 2023
larshg
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part F of #5665 to add the
modernize-use-default-member-initcheck forclang-tidy