-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace: hard code paths instead of using pkg-config #13309
Comments
If possible, I would like to request that hard-coded paths be hoisted to top-level constants, easy to discover if possible, and easy to hack with (with standard disclaimer of at-your-own-risk). That seems to be the case presently, just wanted to make sure I formulated the request. Example workflow: |
Would a Example for github archives: drake/tools/workspace/github.bzl Lines 40 to 43 in 6a068e3
|
I think so, as long as it can affect all occurrences of the Python interpreter; I'm guessing you could do that by generating a Skylark file with that macro, and then pull it back out? |
Ah, I see now. I think you are talking about python interpreter paths, not pkg-config paths. This issue is just about pkg-config. However, I think you're right in any case that if more info about the python interpreter ends up being hard-coded, we should be sure there's a mechanism to adjust it for experimentation. But I think as long as we follow DRY like we usually do, the places to adjust for experimentation will be few. |
Sounds good. Sorry to clutter the scope, just hopped through the philosophical link from #13400. |
After #17231 wraps up, we will be using much less via
I think those will be sufficiently safe to leave alone without much risk. |
pkg-config
files are frequently broken since they are (unfortunately) rarely tested by upstream projects and are frequently patched by distribution packagers. On Focal,libjpeg.pc
andyaml-cpp.pc
are broken at release, while on Mac, numerous files are broken on an ongoing basis. We only support three configurations, so hard coding paths is not a huge deal at this time.The text was updated successfully, but these errors were encountered: