Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python_direct_link target on Focal #13400

Merged
merged 1 commit into from
May 26, 2020
Merged

Fix python_direct_link target on Focal #13400

merged 1 commit into from
May 26, 2020

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented May 26, 2020

Relates #13102. Ultimately, this probably falls under the same philosophy as #13309, but this is the obvious fix.


This change is Reviewable

@jamiesnape jamiesnape added priority: low unused team: kitware component: build system Bazel, CMake, dependencies, memory checkers, linters labels May 26, 2020
@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-release please.

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for review.

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: feature.

+@sammy-tri for platform review per schedule, please.

Reviewed 1 of 1 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri)

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),jwnimmer-tri(platform)

@jamiesnape jamiesnape merged commit a167508 into RobotLocomotion:master May 26, 2020
@jamiesnape jamiesnape deleted the python-direct-link branch May 26, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants