[build] Small fixes in prep for bzlmod #22330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazelignore: Delete long-since unused file (unrelated to bzlmod). java: Repository names will no longer be allowed to begin with an underscore; fix by adding a longer drake-specific prefix for clarity. lcm, scs: Remove stray leading @ from //conditions:default; the meaning of the extra @ changes with bzlmod and the recommended spelling for built-in conditions should be without it. spgrid: The native repository rules will be disabled in bzlmod; instead, we'll load the starlark implementation of the rule. vtk: Include path hacks like -Iexternal/something are no longer valid with bzlmod; instead, use the canonical 'includes = []' attribute for a cc_library rule.
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@xuchenhan-tri for both reviews, please (low priority -- need not happen this CY). |
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #20731.
FYI my WIP integration branch is here, but hopefully these clean-ups stand on their own as being obviously less hacky in the first place, bzlmod or not.
This change is