Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demos): wrong argument name and type in priority of task #325

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix(demos): wrong argument name and type in priority of task #325

merged 2 commits into from
Nov 28, 2024

Conversation

boczekbartek
Copy link
Member

@boczekbartek boczekbartek commented Nov 28, 2024 •
edited
Loading

Please don't squash this PR!

Purpose

Proposed Changes

  • fix argument name and rename whitelist to allowlist

Issues

Testing

NOTE: binaries were downloaded using likns from Simulation Demos

  • rosbot demo
ros2 launch examples/rosbotxl.launch.xml game_launcher:=/home/bboczek/Downloads/RAIROSBotXLDemoGamePackage/RAIROSBotXLDemo.GameLauncher
# terminal 1
python examples/agriculture-demo.py --tractor_number 1
# terminal 2
/home/bboczek/Downloads/RAIAgricultureDemoGamePackage/RAIAgricultureDemo.GameLauncher

@boczekbartek boczekbartek mentioned this pull request Nov 28, 2024
Open
@boczekbartek boczekbartek changed the title fix(demos): wrong argument name: whitelist -> allowlist fix(demos): wrong argument name and type in priority of task Nov 28, 2024
@boczekbartek boczekbartek marked this pull request as ready for review November 28, 2024 10:51
@maciejmajek maciejmajek merged commit 53b457f into development Nov 28, 2024
9 checks passed
@maciejmajek maciejmajek deleted the fix/wrong_argument_name_in_demos branch November 28, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbrw adamdbrw adamdbrw approved these changes

@maciejmajek maciejmajek maciejmajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boczekbartek @adamdbrw @maciejmajek