host_new>content>errata tab pagination #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damoore044
added
CherryPick
damoore044
force-pushed
the
errata-tab-pagination
branch
from
593616d to
983af33
Compare
airgun/entities/host_new.py
Outdated
Comment on lines
318
to
321
| view.content.errata.select() | ||
| # pass empty search to show any and all, | ||
| # if a previous method left the searchbar filled | ||
| view.content.errata.searchbar.fill(' ') |
There was a problem hiding this comment.
Please correct this. We won't be applying the ' ' string
There was a problem hiding this comment.
Yes, we made a new method to clear the SearchInput searchbar (widgets.py), which was unintentionally left occupied by search value passed to apply_erratas method (host_new.py).
Now, we clear the searchbar after selecting and applying erratas by search, so that the passed search does not persist.
sambible
approved these changes
Jan 19, 2024
damoore044
force-pushed
the
errata-tab-pagination
branch
2 times, most recently
from
c85c011 to
95dd963
Compare
omkarkhatavkar
approved these changes
Jan 25, 2024
|
@damoore044 looks good can you take a look at pre-commit failures? |
vsedmik
approved these changes
Jan 25, 2024
damoore044
force-pushed
the
errata-tab-pagination
branch
2 times, most recently
from
1bf49f2 to
a4339e6
Compare
damoore044
force-pushed
the
errata-tab-pagination
branch
2 times, most recently
from
6c4ad18 to
4aae50c
Compare
Click button to clear searchbar docstring fix
damoore044
force-pushed
the
errata-tab-pagination
branch
from
4aae50c to
9aac65b
Compare
ColeHiggins2
approved these changes
Jan 26, 2024
vsedmik
approved these changes
Jan 26, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Click button to clear searchbar docstring fix (cherry picked from commit 5b0ca76)
sambible
pushed a commit
that referenced
this pull request
Jan 26, 2024
Click button to clear searchbar docstring fix (cherry picked from commit 5b0ca76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Solution
-Added new method
clear()toSearchInputclass (aigun/widgets.py)-usage in the airgun view like so
view.content.errata.searchbar.clear()-Now using this in
apply_erratas()method (entities/host_new.py), to clear the searchbar of any possible value present, when no search passed toapply_erratas(), meaning show and apply all errata with a blank searchbar.-We also
clearthe searchbar inapply_erratas()after installing, that way any search value passed does not persist in the searchbar.Issue, ResolvedWhen reading info from PF4Pagination object in views/host_new.py@362, we get an empty dictionary with no information. SolvedWhen the methodapply_erratas(entity, search)is run, it will leave the searchbar filled, and keep it filled until the view is reset.Workaround: Before accessingview.content.errata.pagination, we pass ' ' to searchbar, to display all available errata unfiltered. In case the searchbar was left occupied by a method run previously. I have been looking for a better way or built in method to clear the searchbar /unfilter, before geting pagination.