Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[comp-eval] UI>content>errata tab, Pagination testing #13767

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[comp-eval] UI>content>errata tab, Pagination testing #13767

merged 1 commit into from
Jan 25, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Jan 11, 2024 •
edited
Loading

Update Errata UI Pagination testing

  • to standards for 6.15.0 for setup w/ global registration, and new host UI views
  • depends on airgun#1152

Implement

  • use of registered host fixture, setup w/ global registration, subscribed to content.
  • method to publish and promote cv, wait for any task(s).
  • migrate Airgun UI view; from legacy contenthost UI > errata page ,
    to new host UI > content > errata tab .

Handle Failure: expected updated pagination, but remains the same:

  • Sometimes, applicable_errata_count for the host has already updated after some install, but pagination on the table remains the same as before. I used wait_for to give the new host>content>errata tab time to reload with updated entries /total_items/total_pages etc. Timeout set for 30s on the tab loading new table and pagination, in case satellite is slow.

Affected tests and PRT case:

  • test_content_host_errata_page_pagination renamed to test_host_content_errata_tab_pagination
  • test_end_to_end by modifying fixture registered_contenthost
trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination or test_end_to_end'
airgun: 1152

@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 Stream Introduced in or relating directly to Satellite Stream/Master labels Jan 11, 2024
@damoore044 damoore044 force-pushed the errata-tab-pagination branch 4 times, most recently from 14de062 to 26145ec Compare January 12, 2024 17:14
@damoore044 damoore044 mentioned this pull request Jan 12, 2024
Merged
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination or test_end_to_end'
airgun: 1152

@damoore044 damoore044 changed the title Pagination modifications in new host UI>errata tab Pagination modifications in new host UI>content>errata tab Jan 12, 2024
@damoore044 damoore044 changed the title Pagination modifications in new host UI>content>errata tab [comp-eval] UI>content>errata tab, Pagination testing Jan 12, 2024
@damoore044 damoore044 force-pushed the errata-tab-pagination branch from 26145ec to 087636e Compare January 18, 2024 12:04
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 marked this pull request as ready for review January 18, 2024 12:11
@damoore044 damoore044 requested a review from a team as a code owner January 18, 2024 12:11
@damoore044 damoore044 force-pushed the errata-tab-pagination branch from 087636e to 64efaf9 Compare January 18, 2024 18:06
@damoore044 damoore044 requested review from a team and removed request for a team January 18, 2024 18:08
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 force-pushed the errata-tab-pagination branch from 2746989 to 2124454 Compare January 18, 2024 23:11
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

1 similar comment
@vijaysawant
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 force-pushed the errata-tab-pagination branch from 598307d to cf797ed Compare January 19, 2024 12:58
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 force-pushed the errata-tab-pagination branch from cf797ed to ac03530 Compare January 19, 2024 14:19
@vsedmik
Copy link
Contributor

vsedmik commented Jan 22, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 force-pushed the errata-tab-pagination branch 3 times, most recently from c5d3e43 to dea198c Compare January 23, 2024 18:18
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 force-pushed the errata-tab-pagination branch from dea198c to 6a7ecf1 Compare January 24, 2024 16:27
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

@damoore044 damoore044 force-pushed the errata-tab-pagination branch from 6a7ecf1 to d8920cf Compare January 24, 2024 17:32
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination'
airgun: 1152

JacobCallahan
JacobCallahan requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor request. well done

tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved
sambible
sambible approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending docstring fix. nice stuff

vijaysawant
vijaysawant requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to remove assersion condition from test module, because it is already handled inside fixture

tests/foreman/ui/test_errata.py Outdated
module_lce,
)
registered_contenthost.add_rex_key(satellite=module_target_sat)
assert registered_contenthost.subscribed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not require, as subscription status already asserted inside registered_contenthost fixture after registration of content host.

Suggested change
assert registered_contenthost.subscribed

vsedmik
vsedmik approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking comment.

tests/foreman/ui/test_errata.py Outdated

activation_key = errata_host_ak.read()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This read could be done and returned by the fixture already on L218.

@damoore044
Pagination in new host UI>errata tab
8e241f5 
wait_for() reload of errata tab, handle pagination exceptions

Clarify comments
@damoore044 damoore044 force-pushed the errata-tab-pagination branch from d8920cf to 8e241f5 Compare January 25, 2024 17:51
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination or test_end_to_end'
airgun: 1152

1 similar comment
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_host_content_errata_tab_pagination or test_end_to_end'
airgun: 1152

@JacobCallahan JacobCallahan merged commit 86569dd into SatelliteQE:master Jan 25, 2024
6 checks passed
This was referenced Jan 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@sambible sambible sambible approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@omkarkhatavkar omkarkhatavkar Awaiting requested review from omkarkhatavkar

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

Assignees

@damoore044 damoore044

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damoore044 @vijaysawant @vsedmik @JacobCallahan @sambible