-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISS refactor - batch 2 #12347
ISS refactor - batch 2 #12347
Conversation
Second batch of changes coming from the ISS evaluation: - enable_rhel_repo helper replaced by parametrized fixture - added other fixtures for importing orgs - addressed updates as per PX comment - merged three cases to export/import CV using parametrization - moved to SCA org as default
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to push for all the repos, and get some special sauce worked out to allow for it. The closer we can get to testing actual customer systems, the more value tests like that (replicating customer environments) provide.
Otherwise, changes look good, don't see anything glaringly wrong. ack pending PRT
Maybe we could create some session or module scoped big setup for the "Export sync" to allow that. We need create some special sort of setup for "Network sync" anyway, so I would scope that out to a different PR. |
Second batch of changes coming from the ISS evaluation
Introduced changes:
org
fixtures, which are used for export._enable_rhel_repo
helper function was replaced by parametrized fixture and used through the module.test_positive_export_import_redhat_cv
:test_positive_export_complete_version_rh_repo
- was practically same as the first (export) part of the above case.test_positive_export_import_redhat_cv_with_huge_contents
- same as the above case but bigger (rhscl) repo.test_positive_export_import_kickstart_tree
- was astub
but now it's automated by the case aboveNOTE: The original plan was to test all KS and RHEL repos, however, due to the immediate download policy it would require more than the default 100G. So we need to decide if we want to test the real customer scenarios and go big, or use a small subset to stay bellow 100G.
test_positive_export_import_default_org_view
to address the PX comment.target_sat.cli*
and docstrings on touched tests.