Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] - removing the import entities from nailgun and moving target_sat #13060

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[6.14.z] - removing the import entities from nailgun and moving target_sat #13060

merged 1 commit into from
Nov 13, 2023

Conversation

omkarkhatavkar
Copy link

@omkarkhatavkar omkarkhatavkar commented Nov 8, 2023 •
edited
Loading

Problem Statement

Needs to be a cherrypick of #12989 to 6.14.z

Solution

This PR helps to do the cherrypick #12989

@omkarkhatavkar omkarkhatavkar force-pushed the cherrypick_update_target_sat branch from 173da76 to 633ae27 Compare November 8, 2023 14:26
@omkarkhatavkar omkarkhatavkar changed the title removing the import entities from nailgun and moving target_sat [6.14.z] - removing the import entities from nailgun and moving target_sat Nov 8, 2023
@omkarkhatavkar omkarkhatavkar force-pushed the cherrypick_update_target_sat branch from 633ae27 to d126bd3 Compare November 9, 2023 05:16
@omkarkhatavkar omkarkhatavkar added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 9, 2023
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pod_resources_size: large

@pondrejk
Copy link
Contributor

pondrejk commented Nov 9, 2023

Hi @omkarkhatavkar, I pulled in the changes to my existing PR #13048, but I start getting TypeError: Webhooks.__init__() got multiple values for argument 'server_config' after the move from entities.Webhook to target_sat.api.Webhook. Any idea what might to be the problem?

@omkarkhatavkar
Copy link
Author

Hi @omkarkhatavkar, I pulled in the changes to my existing PR #13048, but I start getting TypeError: Webhooks.__init__() got multiple values for argument 'server_config' after the move from entities.Webhook to target_sat.api.Webhook. Any idea what might to be the problem?

checking

@omkarkhatavkar omkarkhatavkar mentioned this pull request Nov 9, 2023
Merged
This was referenced Nov 9, 2023
Merged
Merged
Merged
@omkarkhatavkar
Copy link
Author

Hi @omkarkhatavkar, I pulled in the changes to my existing PR #13048, but I start getting TypeError: Webhooks.__init__() got multiple values for argument 'server_config' after the move from entities.Webhook to target_sat.api.Webhook. Any idea what might to be the problem?

This is resolved using Nailgun PR here SatelliteQE/nailgun#1029, Thanks @pondrejk raising it up

@omkarkhatavkar omkarkhatavkar requested review from jyejare, JacobCallahan and a team November 10, 2023 05:51
@pondrejk pondrejk merged commit 285d7a6 into SatelliteQE:6.14.z Nov 13, 2023
10 of 11 checks passed
@ogajduse ogajduse linked an issue Nov 16, 2023 that may be closed by this pull request
[Failed-AutoCherryPick] - removing the from nailgun import entities and moving target_sat, module_target_sat #13053
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@jyejare jyejare Awaiting requested review from jyejare

Assignees

@omkarkhatavkar omkarkhatavkar

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - removing the from nailgun import entities and moving target_sat, module_target_sat
3 participants
@omkarkhatavkar @pondrejk @JacobCallahan