Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added help icons to admin and management pages #1264

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Added help icons to admin and management pages #1264

merged 6 commits into from
Jan 11, 2024

Conversation

SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Dec 13, 2023

Motivation and Context

This PR adds some info icons to the admin pages so admins and lecturers have easier access to the needed information.

Description

You can now hover over small "i" icons to view some information about it

Steps for Testing

Prerequisites:

  • 1 Lecturer / Admin
  1. Log in
  2. Navigate to any admin or course management page
  3. Hover over the icons

Screenshots

image
image

Copy link

Your Testserver will be ready at https://1264.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@SebiWrn SebiWrn self-assigned this Dec 27, 2023
@SebiWrn SebiWrn enabled auto-merge (squash) January 9, 2024 19:55
@SebiWrn SebiWrn requested a review from YiranDuan721 January 10, 2024 14:52
@YiranDuan721
Copy link
Contributor

The help icons work perfect. I really like the design, it's clean and easy to read and reference.
Perhaps the exact wording of the help message could be double-checked before deployment, for example the documentation URL doesn't seem to be enabled at the moment.

Copy link
Contributor

@DawinYurtseven DawinYurtseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep that comment from Yiran in mind later on, but it looks good

@SebiWrn SebiWrn merged commit f1f5e3d into dev Jan 11, 2024
8 checks passed
@SebiWrn SebiWrn deleted the enh/help-icons branch January 11, 2024 14:57
@DawinYurtseven DawinYurtseven restored the enh/help-icons branch January 11, 2024 14:57
SebiWrn added a commit that referenced this pull request May 7, 2024
* Added help icons to some admin pages and fixed worker pipeline for github to show current version instead of version sha

* Added help icons to some admin pages and fixed worker pipeline for github to show current version instead of version sha

* Added help icons to two more admin pages

* Minor updates on layout

* Lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants