fix: modal dismiss #246
fix: modal dismiss #246
Conversation
Getting startedPlease make sure you read our documentation on how to write code for components, stories and styles.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 298 298
Lines 1977 1978 +1
Branches 290 291 +1
=======================================
+ Hits 1962 1963 +1
Misses 13 13
Partials 2 2 ☔ View full report in Codecov by Sentry. |
| code: "Escape", | ||
| keyCode: 27, | ||
| }); | ||
| expect(screen.queryByTestId("dismiss-modal-button")).toBeNull(); |
There was a problem hiding this comment.
no me quedó claro la ejecución de esta prueba, si en el modal que no tiene el dismiss ejecutamos Escape cuando vamos a verificar el elemento con el testId dismiss-modal-button no deberiá existir? .. Eso quiere decir que con el Escape se estaría cerrando? 🤔
There was a problem hiding this comment.
Hola @harrytiendanube, gracias por la observación. En realidad el botón no se renderiza nunca, este evento se coló haciendo algunas pruebas. Ahora lo saco
There was a problem hiding this comment.
@harrytiendanube ahí subí los cambios en este commit. No saqué el evento, sino que agregué un assert para determinar que el modal quedó abierto
…gn-system into fix/modal-dismiss
|
* fix(modal): make `onDismiss` optional and conditionally render close button * feat: add change * feat: fix change * feat: add change log * feat: add change log * feat: fix change log * feat: fix change log * feat: fix change logs * fix: versions yml * feat: fix test --------- Co-authored-by: dommirr <[email protected]> Co-authored-by: Ignacio Zullo Salvucci <[email protected]> Co-authored-by: Harry Barzola <[email protected]>
* fix: modal dismiss (#246) * fix(modal): make `onDismiss` optional and conditionally render close button * feat: add change * feat: fix change * feat: add change log * feat: add change log * feat: fix change log * feat: fix change log * feat: fix change logs * fix: versions yml * feat: fix test --------- Co-authored-by: dommirr <[email protected]> Co-authored-by: Ignacio Zullo Salvucci <[email protected]> Co-authored-by: Harry Barzola <[email protected]> * fix(tabs): align center buttons (#261) * fix: tabs align center when is full * chore: include patch to components * docs: add changelog * chore: fix version release --------- Co-authored-by: dommirr <[email protected]> Co-authored-by: dommirr <[email protected]> Co-authored-by: Ignacio Zullo Salvucci <[email protected]>
Type
Changes proposed ✔️
@nimbus-ds/[email protected]🐛 Bug fixes
onDismissproperty optional forModalcomponent. IfonDismissis not provided, the modal can no longer be closed by clicking outside or pressing the close buttonModalcomponent whenonDismissis not provided. (#246 by @dommirr)