Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): align center buttons #261

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

harrytiendanube
Copy link
Contributor

@harrytiendanube harrytiendanube commented Dec 18, 2024

Type

  • Bugfix 🐛

Changes proposed ✔️

@nimbus-ds/[email protected]|patch

🐛 Bug fixes

  • We detected that the content of the Tabs, when set to full, was not centered but aligned to the left. (#261 by @harrytiendanube )

@nimbus-ds/[email protected]|patch

🐛 Bug fixes

  • We detected that the content of the Tabs, when set to full, was not centered but aligned to the left. (#261 by @harrytiendanube )

@nimbus-ds/[email protected]|patch

🐛 Bug fixes

  • We detected that the content of the Tabs, when set to full, was not centered but aligned to the left. (#261 by @harrytiendanube )

@harrytiendanube harrytiendanube requested a review from a team as a code owner December 18, 2024 18:26
Copy link

github-actions bot commented Dec 18, 2024

Getting started

Please make sure you read our documentation on how to write code for components, stories and styles.

  • Provide a list of changes
  • Include images to help better visualize your work
  • If your PR closes an issue, please link it
  • Add reviewers
  • Add a label to help better understand what your changes are related to

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release@376fd2c). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             release     #261   +/-   ##
==========================================
  Coverage           ?   99.24%           
==========================================
  Files              ?      298           
  Lines              ?     1979           
  Branches           ?      292           
==========================================
  Hits               ?     1964           
  Misses             ?       13           
  Partials           ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harrytiendanube harrytiendanube changed the title Fix/tabs aling center fix(tabs): align center buttons Dec 18, 2024
@harrytiendanube harrytiendanube changed the base branch from master to release December 18, 2024 18:38
@harrytiendanube harrytiendanube merged commit 5453a39 into release Dec 18, 2024
5 checks passed
@harrytiendanube harrytiendanube mentioned this pull request Dec 18, 2024
5 tasks
harrytiendanube added a commit that referenced this pull request Dec 18, 2024
* fix: tabs align center when is full

* chore: include patch to components

* docs: add changelog
@harrytiendanube harrytiendanube mentioned this pull request Dec 18, 2024
1 task
harrytiendanube added a commit that referenced this pull request Dec 18, 2024
* fix: modal dismiss (#246)

* fix(modal): make `onDismiss` optional and conditionally render close button

* feat: add change

* feat: fix change

* feat: add change log

* feat: add change log

* feat: fix change log

* feat: fix change log

* feat: fix change logs

* fix: versions yml

* feat: fix test

---------

Co-authored-by: dommirr <[email protected]>
Co-authored-by: Ignacio Zullo Salvucci <[email protected]>
Co-authored-by: Harry Barzola <[email protected]>

* fix(tabs): align center buttons (#261)

* fix: tabs align center when is full

* chore: include patch to components

* docs: add changelog

* chore: fix version release

---------

Co-authored-by: dommirr <[email protected]>
Co-authored-by: dommirr <[email protected]>
Co-authored-by: Ignacio Zullo Salvucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants