-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team 5 Economy #67
Merged
Merged
Team 5 Economy #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the amount of currency it has, and check if certain items can be bought.
Implemented the basic class of DropFactory which is for drops, as the currency class has not been implemented, placeholders have been used instead of ServiceLocator calls.
…'s now has a member variable 'name' which describes the currency (e.g. Scrap).
…studio-3 into Team-5--Economy
…ain currency used throughout sprint 1.
…th the currency's throughout the game.
DropComponent can be attached to any entity using Entity.addComponent(new DropComponent(value, Currency); Factory is used to spawn the component entity.
…studio-3 into Team-5--Economy
Note: this is not functional.
…y the amount of currency it has, and check if certain items can be bought.
…'s now has a member variable 'name' which describes the currency (e.g. Scrap).
Implemented the basic class of DropFactory which is for drops, as the currency class has not been implemented, placeholders have been used instead of ServiceLocator calls.
…ain currency used throughout sprint 1.
…th the currency's throughout the game.
DropComponent can be attached to any entity using Entity.addComponent(new DropComponent(value, Currency); Factory is used to spawn the component entity.
Note: this is not functional.
…ed a file for Currency Tests
…rap generating turrets
When clicking a component you can successfully pickup the scrap and increase the economy. (Currently does not update UI)
After clicking a scrap, the UI updates to reflect the change.
Added some base text cases to check if the scrap was properly created.
…studio-3 into Team-5--Economy
Also added additional comments
This was
linked to
issues
Aug 29, 2023
The-AhmadAA
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that lines 77 and 78 have been added in error - this method is for creating a wallTower, it doesn't need an AiTaskComponent
Need to edit out lines 77 and 78 in TowerFactory.java, these lines don't belong in the method. Everything else seems ok |
This was
linked to
issues
Aug 29, 2023
Closed
Closed
8 tasks
Closed
11 tasks
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed all Economy Components mentioned in #15
These include: