abc: Warn about replacing undef bits #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this should be a warning; we only use warnings in Yosys when there's a real problem with the user code. This feels like the kind of "Warning: I was able to optimize your design somewhat" messages that lead people to completely ignore warnings. It would fit better as a regular log message IMO. |
|
OK, I was expecting some pushback on this. We don't want to turn this into insert vendor tool here, after all. Changed it to an ordinary log message. |
|
Though I feel we could make the decision that proper synthesis scripts should never leave undef bits for ABC to find, at which point the warning would be justified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion inspired by #3893