Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix master branch refs #4297

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Mar 23, 2024

I could not find exact change wrt master branch to main branch, but since this already happened, just rename all the master branch references to main.

also relates to Homebrew/homebrew-core#166979

@KrystalDelusion
Copy link
Member

There isn't a commit that marks the change in default branch name, it was purely on the github side. d73f71e was the last commit prior to the change.

There is also an existing PR to update references in the docs, #4292. Yours has a number of whitespace fixes in the affected files, which is great, but if that's the only difference I would rather you were consistent and did it to all of the docs source files. And probably in a separate PR.

@chenrui333
Copy link
Contributor Author

yeah, I can exclude the whitespace changes from the PR if that is the concern in here. (I can also incorporate the pr changes, I did not know that one's existence)

@chenrui333 chenrui333 force-pushed the fix-master-branch-refs branch from 7301bae to 907293d Compare March 24, 2024 04:38
@chenrui333 chenrui333 force-pushed the fix-master-branch-refs branch from 907293d to b57a803 Compare March 24, 2024 04:42
@chenrui333
Copy link
Contributor Author

@KrystalDelusion should be good now.

@KrystalDelusion
Copy link
Member

Thanks. I'll close the other one in favour of this one then.

@chenrui333
Copy link
Contributor Author

the test failure should be unrelated, right?

@KrystalDelusion
Copy link
Member

Looks like it's unrelated and transient. Re run passed.

@nakengelhardt nakengelhardt merged commit 6248d59 into YosysHQ:main Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants