cxxrtl: Prevent wires with input or output ports from being aliased #4406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #4405, having outputs or inputs aliased causes a loss of information in
debug_info
.To prevent this behavior, we stop assigning debug information at the beginning of the
debug_alias
option corresponding logic if the wire is an input and/or an output.One implementation choice here was to choose, for an input that is tied to a constant, whether we should generate:
or
This patch is an implementation for the first one, because we can still query the constant later in the first whereas we would loose the
INPUT
andDRIVEN_COMB
flags in the second one.