Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple client callable #2393

Merged
merged 79 commits into from
Nov 23, 2023
Merged

Decouple client callable #2393

merged 79 commits into from
Nov 23, 2023

Conversation

danieljanes
Copy link
Member

@danieljanes danieljanes commented Sep 19, 2023 •
edited
Loading

danieljanes and others added 30 commits September 19, 2023 20:25
@danieljanes
Decouple client and app
4886c77
@danieljanes
Merge branch 'main' into decouple-client
fb8ba3d
@danieljanes
Merge branch 'main' into decouple-client
fca2187
@danieljanes
Merge branch 'main' into decouple-client
5e5fec6
@danieljanes
Merge branch 'main' into decouple-client
c3e82b7
@danieljanes
Shorten line
1223f90
@danieljanes
Merge branch 'main' into decouple-client
555d89a
@danieljanes
Add comments to main client loop
a7c57d6
@danieljanes
Refactor start_client
9a20a0c
@danieljanes
Merge branch 'main' into decouple-client
d65601b
@danieljanes
Merge branch 'refactor-start-client' into decouple-client
82df0a3
@danieljanes
Format code
32e4973
@danieljanes
Add type hint
11bf509
@danieljanes
Merge branch 'refactor-start-client' into decouple-client
d097096
@charlesbvll
Test with Iterator
a1a647a
@charlesbvll
Working solution (I think)
ce2bbb8
@charlesbvll
Fix imports
7617335
@danieljanes
Merge branch 'refactor-start-client' into decouple-client
d9a7318
@danieljanes
Merge branch 'main' into decouple-client
46acb9d
@danieljanes
Merge branch 'main' into decouple-client
e61c91a
@danieljanes
Move task execution into Flower app
156aad0
@danieljanes
Enable --app in flower-client
a47a760
@danieljanes
Merge branch 'main' into decouple-client
77bfc04
@danieljanes
Add comments to start_client
90058f9
@danieljanes
Handle control messages in a separate function
86c1473
@danieljanes
Change comment
9bc1349
@danieljanes
Merge branch 'refactor-start-client-comments' into refactor-start-cli…
ee87393 
…ent-control-message
@danieljanes
Update comments
1691340
@danieljanes
Update comments
7d732e9
@danieljanes
Format
9f6472f
@panh99 panh99 mentioned this pull request Nov 11, 2023
Merged
@danieljanes danieljanes changed the title Decouple client and app Decouple client callable Nov 21, 2023
@danieljanes danieljanes marked this pull request as ready for review November 21, 2023 10:19
@danieljanes danieljanes mentioned this pull request Nov 21, 2023
Merged
3 tasks
@danieljanes danieljanes enabled auto-merge (squash) November 21, 2023 11:51
tanertopal
tanertopal reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few questions / comments on things I find hard to understand.

examples/mt-pytorch-callable/client.py Show resolved Hide resolved
src/py/flwr/client/app.py Show resolved Hide resolved
src/py/flwr/client/flower.py Outdated Show resolved Hide resolved
src/py/flwr/client/flower.py Outdated Show resolved Hide resolved
@danieljanes danieljanes merged commit 1f9fa75 into main Nov 23, 2023
27 checks passed
@danieljanes danieljanes deleted the decouple-client branch November 23, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danieljanes @tanertopal @charlesbvll @panh99