Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EventDataFrame.copy() #552

Merged
merged 2 commits into from
Sep 14, 2023
Merged

feat: Add EventDataFrame.copy() #552

merged 2 commits into from
Sep 14, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 14, 2023

Description

Adds simple clone method to EventDataFrame class. Needed in #553

Implemented changes

  • EventDataFrame.clone()

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested that copied dataframe has same values
  • Tested that dataframes point to different instances

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f3dd4e3) 100.00% compared to head (ad151d1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #552   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2137      2139    +2     
  Branches       521       521           
=========================================
+ Hits          2137      2139    +2     
Files Changed Coverage Δ
src/pymovements/events/frame.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkrako dkrako merged commit 097cbbb into main Sep 14, 2023
@dkrako dkrako deleted the feature/events-clone branch September 14, 2023 11:06
@dkrako dkrako changed the title feat: Add EventDataFrame.clone() feat: Add EventDataFrame.copy() Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants