-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add events to GazeDataFrame init #553
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 2139 2143 +4
Branches 521 522 +1
=========================================
+ Hits 2139 2143 +4
☔ View full report in Codecov by Sentry. |
e106667
to
33ba497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as usual great work -- the circular import is kinda ugly. please open an issue before merging it
Description
Add events keyword argument to GazeDataFrame initializer.
For a start I would like to keep this rather simple.
#552 must be merged first
Implemented changes
Type of change
How Has This Been Tested?
Checklist: