Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add events to GazeDataFrame init #553

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 14, 2023

Description

Add events keyword argument to GazeDataFrame initializer.
For a start I would like to keep this rather simple.

#552 must be merged first

Implemented changes

  • If events is None: create empty EventDataFrame
  • Else: create copy of passed EventDataFrame

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested attributes after initialization for a few dataframe combinations

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dkrako dkrako mentioned this pull request Sep 14, 2023
13 tasks
@dkrako dkrako marked this pull request as draft September 14, 2023 07:53
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (097cbbb) 100.00% compared to head (01b8c03) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2139      2143    +4     
  Branches       521       522    +1     
=========================================
+ Hits          2139      2143    +4     
Files Changed Coverage Δ
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako force-pushed the feature/gaze-init-events branch from e106667 to 33ba497 Compare September 14, 2023 10:27
@dkrako dkrako marked this pull request as ready for review September 14, 2023 11:28
@dkrako dkrako mentioned this pull request Sep 14, 2023
16 tasks
Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as usual great work -- the circular import is kinda ugly. please open an issue before merging it

src/pymovements/gaze/gaze_dataframe.py Show resolved Hide resolved
src/pymovements/gaze/gaze_dataframe.py Show resolved Hide resolved
@dkrako dkrako merged commit aaa0919 into main Sep 15, 2023
20 checks passed
@dkrako dkrako deleted the feature/gaze-init-events branch September 15, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants