chore: Migrate typing to matplotlib v3.8.0 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2200 2208 +8
Branches 543 545 +2
=========================================
+ Hits 2200 2208 +8
☔ View full report in Codecov by Sentry. |
|
would resolve #562 |
SiQube
force-pushed
the
upgrade-matplotlib-380
branch
from
bc1af47 to
90bc557
Compare
SiQube
commented
Sep 15, 2023
dkrako
requested changes
Sep 22, 2023
dkrako
approved these changes
Sep 22, 2023
dkrako
changed the title
josephine-funken
pushed a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are still a couple of TODOs, see pydata/xarray#8030, but we can upgrade to
matplotlib==3.8.0.I'll leave it up to my fellow code owners @dkrako and @prassepaul to decide which way to merge. either this one or #561. this PR would resolve #562