Update ApplicationSignals log group name and adjust AWS service name #197
Conversation
bjrara
changed the title
| @@ -32,7 +32,7 @@ const ( | |||
|
|
|||
| // AppSignals EMF config | |||
| appSignalsMetricNamespace = "AppSignals" | |||
There was a problem hiding this comment.
should we also update Metric namespace here?
There was a problem hiding this comment.
looks like we will have to change it, it is used to determine whether we should inject AppSignals flag in useragent
bjrara
force-pushed
the
aws-cwa-dev
branch
2 times, most recently
from
9d23421 to
ae44f6f
Compare
bjrara
changed the title
|
Are any of these changes planned for upstream? |
Yes we will contribute to the upstream. |
|
From previous merged PR #213:
Failed tests (in the previous PR) were: |
|
Cross referenced check failures with previous pr and validated no changes |
lisguo
merged commit e0e66ca
into
amazon-contributing:aws-cwa-dev
| metric := dps.NumberDataPointSlice.At(i) | ||
| labels := createLabels(metric.Attributes(), instrumentationScopeName) | ||
| labels := createLabels(metric.Attributes()) |
There was a problem hiding this comment.
I guess we'll need to refactor it to make upstream happy on merging.
… AWS service name (#33798) **Description:** Cherry-picking from downstream: amazon-contributing#197 Changes: - unify the log group name to /aws/application-signals/data. - rename Application Signals metric namespace. - removed OTelLib name label from EMF log --------- Co-authored-by: Mengyi Zhou (bjrara) <[email protected]>
Description:
This PR is a subset of aws/amazon-cloudwatch-agent#1133.
Testing:
Documentation: