-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pixi.lock
to git lfs
#189
Conversation
Note: I guess that now we can also add back to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can we update the lockfile before moving it to LFS?
I forgot to comment, this PR already contains an updated lock file. |
Note that as now the diff will be quite obscure (and even before they were not super clear given the size of the lockfile) in the future to update the lockfile we could use something like https://pixi.sh/dev/advanced/updates_github_actions/#how-to-use (without the schedule stuff) that adds in the PR a description of the changes. |
This is a good idea. We may need to adapt the example to use git lfs, not a big deal though. |
427eef3
to
76651a6
Compare
I've never been fully convinced of the large size of the
pixi.lock
file directly committed to the git repo. Here below some history of the pixi support and discussions:pixi.toml
#144After chatting with @flferretti and @traversaro, we decided the following solution to prevent the repo to grow too much in size for the benefit of a very small portion of users:
pixi.lock
(we cannot do much from the previous large diffs w/o rewriting history, let's learn the lesson for future projects).pixi.lock
file only if needed.I believe this is a good trade off that works well for us. We can work on extending the documentation in other PRs.
Warning
For future readers, keep in mind that GitHub limits the bandwidth from/to the LFS server. If you have many users pushing/pulling LFS files and don't have an upgraded account, you may finish your monthly quota. If this is the case, you might need to find other solutions to prevent having the
pixi.lock
in your repository.How to test this PR:
📚 Documentation preview 📚: https://jaxsim--189.org.readthedocs.build//189/