-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly optimize computation for RigidContacts
model
#325
Conversation
4839b71
to
878bbfe
Compare
We checked with @flferretti and the time needed to perform Maybe we can close this PR then @flferretti ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @flferretti ! I left a comment
Sorry @CarlottaSartore I skipped your comment! Mmmh yes, then maybe we can close this for now. Do you agree @flferretti ? |
Sure! I also removed a switch of the velocity representation and refactored a bit the function. If you agree I can restore the |
373e854
to
7fcd305
Compare
7fcd305
to
753bb78
Compare
This PR slightly enhances the performances of the
RigidContacts
model by using the pseudoinverse instead of the least-squares method to compute the impact velocity, and removes some unnecessary context managers and assertions📚 Documentation preview 📚: https://jaxsim--325.org.readthedocs.build//325/